Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make log level configurable from command line argument #199

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

s-a-tanjim
Copy link
Contributor

No description provided.

@pfeairheller pfeairheller self-requested a review February 29, 2024 15:05
@pfeairheller pfeairheller self-assigned this Feb 29, 2024
@lenkan
Copy link
Contributor

lenkan commented Feb 29, 2024

Nice. This will also close issue #114 if merged.

@s-a-tanjim
Copy link
Contributor Author

@pfeairheller I saw python version was updated here:

keria/setup.py

Line 76 in c8648e8

python_requires='>=3.12.1',
. But the Dockerfile was not updated. So I updated that in this PR as well.

@pfeairheller
Copy link
Member

@s-a-tanjim can you please rebase this PR on development? You need to pick up the fixes I just pushed to fix tests broken from PR WebOfTrust/keripy#701. As soon as the tests pass, I'd like to merge this in.

@s-a-tanjim
Copy link
Contributor Author

@pfeairheller I rebased with the latest development branch.

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (48e75c2) to head (99e9b74).

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #199   +/-   ##
============================================
  Coverage        93.14%   93.14%           
============================================
  Files               38       38           
  Lines             6943     6943           
============================================
  Hits              6467     6467           
  Misses             476      476           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pfeairheller pfeairheller merged commit c38a54b into WebOfTrust:development Mar 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants