Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Upstream #1

Merged
merged 123 commits into from
Oct 9, 2019
Merged

Merge Upstream #1

merged 123 commits into from
Oct 9, 2019

Conversation

Wealthyturtle
Copy link
Owner

Description


Target Minecraft Versions:
Requirements:
Related Issues:

ShaneBeee and others added 30 commits May 28, 2019 14:31
- New expression for view distance of player
- Changes as requested by Blue
- Change integer to return number instead (as suggested by Blue)
…e.java

Co-Authored-By: Gökdeniz <blueyescat123@gmail.com>
…e.java

Co-Authored-By: Gökdeniz <blueyescat123@gmail.com>
…e.java

Co-Authored-By: Gökdeniz <blueyescat123@gmail.com>
- Fixed a small issue that goes with the suggested change from blue
Blueyescat and others added 29 commits September 27, 2019 11:11
Skript's API doesn't use them anywhere else so it's inconsistent
and thus, doesn't really fit with the current design in general.
Furthermore, Skript relies on static null analysis more than anything
so Optional don't really add anything to the API
 besides it being "pretty" over other solutions. At least for now,
 Optionals don't really seem a feature that needs to be used in Skript.
Still needs testing
Co-Authored-By: Giovanni <42092549+Matocolotoe@users.noreply.github.com>
@Wealthyturtle Wealthyturtle merged commit e72ed85 into Wealthyturtle:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.