forked from SkriptLang/Skript
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Upstream #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New expression for view distance of player
- Changes as requested by Blue
- Change integer to return number instead (as suggested by Blue)
…e.java Co-Authored-By: Gökdeniz <blueyescat123@gmail.com>
…e.java Co-Authored-By: Gökdeniz <blueyescat123@gmail.com>
…e.java Co-Authored-By: Gökdeniz <blueyescat123@gmail.com>
- Fixed a small issue that goes with the suggested change from blue
This reverts commit 0fa7f38
This reverts commit c31c1c5
This reverts commit 5586863
This reverts commit 6667201
…essary data from signatures.
…. General function system cleanup.
Skript's API doesn't use them anywhere else so it's inconsistent and thus, doesn't really fit with the current design in general. Furthermore, Skript relies on static null analysis more than anything so Optional don't really add anything to the API besides it being "pretty" over other solutions. At least for now, Optionals don't really seem a feature that needs to be used in Skript.
Still needs testing
…to Wealthyturtle-patch-12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Target Minecraft Versions:
Requirements:
Related Issues: