Skip to content

Commit

Permalink
Issue #149: Remove graphicx dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
noraj committed Mar 25, 2020
1 parent 5f740f8 commit f65b80c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion eisvogel.tex
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@
\usepackage{footnotebackref}
$endif$
$if(graphics)$
\usepackage{graphicx,grffile}
\usepackage{graphicx}
\makeatletter
\def\maxwidth{\ifdim\Gin@nat@width>\linewidth\linewidth\else\Gin@nat@width\fi}
\def\maxheight{\ifdim\Gin@nat@height>\textheight\textheight\else\Gin@nat@height\fi}
Expand Down

2 comments on commit f65b80c

@fasterit
Copy link

@fasterit fasterit commented on f65b80c May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break image includes that have a . (dot) in the filename besides the one before the extension.

! LaTeX Error: Unknown graphics extension: .9_CVEs.png.
...
l.1053 ...{../200412_22:02_Wordpress_4.9_CVEs.png}

(on Debian Stable, Ubuntu LTS etc.)

@Wandmalfarbe
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see jgm/pandoc#5848 and the commit message from jgm/pandoc@4d5fd9e

Remove include of grffile from default latex template.

This package is needed for proper handling of image filenames
containing periods (in addition to the period before the
extension).

Unfortunately, grffile breaks in the latest texlive update.
Until a fix is released (see ho-tex/oberdiek#73) it seems best
to remove this from the default template.

This may cause problems if you have filenames with periods.
The workaround is to put \usepackage{grffile} in header-includes,
and be sure you're using an older version of texlive packages.

See #5848. We will leave that issue open to remind us to
check upstream, and restore grffile when it's possible to
do so.

Please sign in to comment.