Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voice packet validation for OPUS decoder #12

Merged
merged 5 commits into from
Mar 6, 2020

Conversation

d3m37r4
Copy link
Contributor

@d3m37r4 d3m37r4 commented Jan 25, 2020

This fixes vulnerable client-side attack via invalid voice packet.
Correction in Revoice: s1lentq/revoice@5f71fde

Main.cpp Outdated Show resolved Hide resolved
Main.cpp Outdated Show resolved Hide resolved
@WPMGPRoSToTeMa WPMGPRoSToTeMa self-assigned this Mar 5, 2020
@WPMGPRoSToTeMa
Copy link
Owner

@d3m37r4 please double-check my changes.

Main.cpp Outdated Show resolved Hide resolved
Copy link

@afwn90cj93201nixr2e1re afwn90cj93201nixr2e1re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

да.

@d3m37r4
Copy link
Contributor Author

d3m37r4 commented Mar 5, 2020

@WPMGPRoSToTeMa, mb 0 - empty voice packet, -1 invalid. I could be wrong. In the first case, everything should be correct.

@afwn90cj93201nixr2e1re
Copy link

У Артема все в порядке теперь.
#14, как мы выяснили 0 уже используется, поэтому нужно -1. Так что -1.

Main.cpp Outdated Show resolved Hide resolved
@WPMGPRoSToTeMa WPMGPRoSToTeMa changed the title Added voice packet validation Add voice packet validation Mar 6, 2020
@WPMGPRoSToTeMa WPMGPRoSToTeMa changed the title Add voice packet validation Add voice packet validation for OPUS decoder Mar 6, 2020
@WPMGPRoSToTeMa WPMGPRoSToTeMa merged commit 2c740e0 into WPMGPRoSToTeMa:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants