-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add voice packet validation for OPUS decoder #12
Merged
WPMGPRoSToTeMa
merged 5 commits into
WPMGPRoSToTeMa:master
from
d3m37r4:VoicePacketValidation
Mar 6, 2020
Merged
Add voice packet validation for OPUS decoder #12
WPMGPRoSToTeMa
merged 5 commits into
WPMGPRoSToTeMa:master
from
d3m37r4:VoicePacketValidation
Mar 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3m37r4
force-pushed
the
VoicePacketValidation
branch
from
March 4, 2020 14:50
1d0cb07
to
1a6753e
Compare
afwn90cj93201nixr2e1re
approved these changes
Mar 4, 2020
@d3m37r4 please double-check my changes. |
WPMGPRoSToTeMa
approved these changes
Mar 5, 2020
afwn90cj93201nixr2e1re
approved these changes
Mar 5, 2020
s1lentq
suggested changes
Mar 5, 2020
afwn90cj93201nixr2e1re
suggested changes
Mar 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
да.
@WPMGPRoSToTeMa, mb 0 - empty voice packet, -1 invalid. I could be wrong. In the first case, everything should be correct. |
У Артема все в порядке теперь. |
d3m37r4
commented
Mar 5, 2020
afwn90cj93201nixr2e1re
approved these changes
Mar 5, 2020
WPMGPRoSToTeMa
changed the title
Added voice packet validation
Add voice packet validation
Mar 6, 2020
WPMGPRoSToTeMa
changed the title
Add voice packet validation
Add voice packet validation for OPUS decoder
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes vulnerable client-side attack via invalid voice packet.
Correction in Revoice: s1lentq/revoice@5f71fde