Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrelayed messages should count as failures for the assigned validator #2173

Closed
maharifu opened this issue Sep 18, 2024 · 0 comments · Fixed by palomachain/paloma#1295
Closed
Assignees
Labels
bug Something isn't working paloma

Comments

@maharifu
Copy link

Currently if the assigned validator fails to relay a message it is simply removed from the queue and does not count as a failure to the assigned validator. This means if a validator is incapable or unwilling to relay messages, it's success rate metric never changes.

When removing messages from the queue, we need to check if it was relayed (it has public or error data). If it does not, then we need to consider it a failure and update the validator metrics.

@maharifu maharifu self-assigned this Sep 18, 2024
@maharifu maharifu added bug Something isn't working paloma labels Sep 18, 2024
taariq pushed a commit to palomachain/paloma that referenced this issue Sep 19, 2024
# Related Github tickets

- Closes VolumeFi#2173

# Background

Currently if the assigned validator fails to relay a message it is
simply removed from the queue and does not count as a failure to the
assigned validator. This means if a validator is incapable or unwilling
to relay messages, it's success rate metric never changes.

When removing messages from the queue, we check if it was relayed (it
has public or error data). If it does not, then we consider it a failure
and update the validator metrics.

# Testing completed

- [x] test coverage exists or has been added/updated
- [x] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working paloma
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant