Feature/110 fix the bug in EllipsoidTissueRegion #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
hayakawa16
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Change "visually" looks good and all unit tests pass. I started up a simulation with infile_ellip_FluenceOfRhoAndZ.txt and 100,000 photons to stress test code and make sure somehow flow doesn't flow out bottom of case.
hayakawa16
approved these changes
Oct 7, 2023
There was a problem hiding this comment.
I performed my test run with N=100,000 photons and a specified a true ellipse (not a sphere) to make sure code gets exercised. All looks good. It took 20 hours on my new laptop though! I think the laptop goes to sleep and pauses during the simulation? This does not happen on linux.
lmalenfant
deleted the
feature/110-fix-the-bug-in-ellipsoidtissueregion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the unreachable code by changing case 0: (no intersections) to default: