Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add additional folders for symlinks #101

Conversation

katewilga
Copy link
Contributor

@katewilga katewilga commented Apr 7, 2023

[edit] added project settings image

Updated the preferences pane to allow users to add additional folders to be symlinked when creating a new clone

image

image

This provides a solution to both of these issues

[Feature Request] Select extra dependencies on Clone creation #51
[Feature Request] symbolic link to Library/PackageCache #67

@katewilga katewilga marked this pull request as ready for review April 7, 2023 23:40
@katewilga katewilga marked this pull request as draft April 7, 2023 23:40
@katewilga katewilga marked this pull request as ready for review April 7, 2023 23:41
Mike Wilga added 3 commits April 10, 2023 09:52
… within the project scope. previous updates only allowed this within the user scope
@RunninglVlan
Copy link

RunninglVlan commented Apr 19, 2023

I tried your change and don't understand where that ScriptableObject is used and why is it needed? I see that you save the list in EditorPrefs
Update: Alright, I found it in Project Settings, but I don't understand why 2 places are needed. I don't think many would like to have some additional scriptable in their project

@katewilga
Copy link
Contributor Author

Thank you for the comments @RunninglVlan, it's nice to meet someone in the pull request void :)

These options are available in two places because
Editor Preferences are saved to the local machine,
whereas Project Settings are set for all users of the project.

In our case, we have multiple users in the project.
We need to be sure some folders are symlink'ed project wide via Project Settings.
While some folders are only symlink'ed locally via Editor Preferences

Regarding, ScriptableObjects, afaik, this is standard practice when adding a menu to Project Settings.
Looking at other plugins, this is what they do.
Other plugins do seem to contain their ScriptableObject settings .asset files within their respective plugin folders, which I should do as well. I will fix that.

@RunninglVlan
Copy link

RunninglVlan commented Apr 19, 2023

What other plugins are you referring to? I'd like to see examples too =)
I see that some Unity project settings are saved in /ProjectSettings
BTW, we're using ParrelSync as a package, so it isn't located in plugin folder, but in /Library/PackageCache... and you can't write there.
I also noticed that you're using simple ScriptableObject, I just found out there's also ScriptableSingleton, for example, Rider package uses that. I guess it can be used for project settings, but I haven't checked that yet

@katewilga
Copy link
Contributor Author

katewilga commented Apr 19, 2023

I see that some Unity project settings are saved in /ProjectSettings

I noticed that as well, but I don't see any external packages doing that.
I have not investigated, I assume this is for native settings only.

What other plugins are you referring to? I'd like to see examples too =)

The other packages don't always put them in the "plugins" folder,
but they do seem to put them in a more purposeful location that what I had before.
A quick search of "settings t:scriptableobject" in Project explorer, this is what is found:

Assets/Wwise/ScriptableObjects/AkWwiseInitializationSettings.asset
Assets/Resources/DOTweenSettings.asset
Assets/Configs/Input/InputSystem.inputsettings.asset
Assets/Plugins/TextMesh Pro/Resources/TMP Settings.asset
Assets/Render/UniversalRenderPipelineGlobalSettings.asset

there's also ScriptableSingleton

nice find!
that would have been nice two days ago when I was applying the singleton pattern to a different ScriptableObject ;)
as far as applying it to this pull, I don't have the cycles at this time to refactor

@314pies
Copy link
Contributor

314pies commented Apr 30, 2023

LGTM! Thanks, @mwilga!

@314pies 314pies merged commit cfaab20 into VeriorPies:master Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants