入力テンソルをvisitor patternで捌く #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Nov 16, 2023
Comment on lines
+110
to
+113
| pub(crate) trait PushInputTensor { | ||
| fn push_int64(&mut self, tensor: Array<i64, impl Dimension + 'static>); | ||
| fn push_float32(&mut self, tensor: Array<f32, impl Dimension + 'static>); | ||
| } |
There was a problem hiding this comment.
補足: これはenum OutputTensorと対になる感じかと思います。
enum InputTensor { Int64(_), Float32(_) }というのも考えたのですが、経路を遠くしてまで統一性を出す必要は無いかなと思い、この形にしました。
Hiroshiba
approved these changes
Nov 17, 2023
sevenc-nanashi
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
FIXMEを一つ解消します。
文脈: #675 (comment)
関連 Issue
#545
その他