Fixes broken NPM package (hopefully) #1413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hey, thanks for putting together this package it seems super useful! Anyways while I was attempting to use the latest version of this package (
0.18.1
) it looks likedist/package.json
is pointing to several files that don't actually appear to exist resulting in some runtime errors (documented in #1403):Fixes #1403
When I cloned this package locally and ran
yarn build
it looks like everything is actually being built todist/src
like so:In this PR I just updated
tsconfig.json
to remove therootDir
. Runningyarn build
with that change builds out the correct directory structure:Does this seem like the right fix? I also saw that
bob
the build tool was being used but couldn't figure out if there was some way to pass this configuration setting to that tool.