Remove Test Cruft #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there were a lot of superfluous tests. They were building wheels and testing packages multiple times, as well as building WASM binaries. Most of these weren't even run, because they would only be dispatched on a change to the nonexistant "master" branch (this repository uses "main"). The only functionality that might be missed is the ability to create a release automatically, but that seems sufficiently far off in the future to not worry about that for now. The tests that have been kept now test against a lesser array of Python versions (3.7 and 3.11 in this case), as well as only testing on Ubuntu instaid of Ubuntu, Windows, and macOS. Fixes UofUEpiBio#12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there were a lot of superfluous tests. They were building wheels and testing packages multiple times, as well as building WASM binaries. Most of these weren't even run, because they would only be dispatched on a change to the nonexistent "master" branch (this repository uses "main").
The only functionality that might be missed is the ability to create a release automatically, but that seems sufficiently far off in the future to not worry about that for now.
The tests that have been kept now test against a lesser array of Python versions (3.7 and 3.11 in this case), as well as only testing on Ubuntu instead of Ubuntu, Windows, and macOS.
Fixes #12. Apologies for the late PR, I'm affected by the Xfinity outage.