chore: use v4 quoter gas estimate #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
xrsv
reviewed
Sep 20, 2024
xrsv
approved these changes
Sep 20, 2024
jsy1218
force-pushed
the
siyujiang/route-277-tech-debt-update-v4-quoter-and-mixed-quoter-deploy-address
branch
from
231aed3
to
ba20c8b
Compare
jsy1218
force-pushed
the
siyujiang/route-245-tech-debt-sor-gas-model-should-use-the-gas-estimate-returned
branch
from
379149c
to
da15feb
Compare
jsy1218
changed the base branch from
siyujiang/route-277-tech-debt-update-v4-quoter-and-mixed-quoter-deploy-address
to
graphite-base/713
jsy1218
force-pushed
the
siyujiang/route-245-tech-debt-sor-gas-model-should-use-the-gas-estimate-returned
branch
from
da15feb
to
9ba5645
Compare
jsy1218
force-pushed
the
graphite-base/713
branch
from
ba20c8b
to
f5857a6
Compare
jsy1218
force-pushed
the
siyujiang/route-245-tech-debt-sor-gas-model-should-use-the-gas-estimate-returned
branch
from
9ba5645
to
df77bfc
Compare
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (09/23/24)4 reviewers were added and 1 assignee was added to this PR based on 's automation. |
…thValidQuote.gasEstimate, because of the additional gas overhead from provider.additionalGasOverride
jsy1218
force-pushed
the
siyujiang/route-245-tech-debt-sor-gas-model-should-use-the-gas-estimate-returned
branch
from
df77bfc
to
3b7f044
Compare
jsy1218
deleted the
siyujiang/route-245-tech-debt-sor-gas-model-should-use-the-gas-estimate-returned
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore
What is the current behavior? (You can also link to an open issue here)
Currently, we have the v4 offchain gas heuristics.
What is the new behavior (if this is a feature change)?
We are now using the v4 gas estimate from the quoter itself.
Other information: