Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix base multicall multichunk for gas #304

Merged
merged 3 commits into from
Aug 12, 2023
Merged

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Aug 12, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Base mainnet integ-tests are failing due to gas https://app.warp.dev/block/tCQ8sTuuw42vtQjttnDlAE.

  • What is the new behavior (if this is a feature change)?
    Reduce Base multichunk so swap integ-tests aren't failing anymore. https://app.warp.dev/block/qBFFXAPgnzIsqjX4atI7Pd

  • Other information:
    Not sure when we started to see BASE gas failures. But it might impact prod, as we started seeing the gas error metrics recently:

Screenshot 2023-08-11 at 9 43 54 PM

The timeline doesn't really match, but we could keep an eye out.

@jsy1218 jsy1218 self-assigned this Aug 12, 2023
Copy link
Contributor

@mikeki mikeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the routing-api config if this config works better

@jsy1218
Copy link
Member Author

jsy1218 commented Aug 12, 2023

We should also update the routing-api config if this config works better

I just realized that we don't override BASE gas params in routing-api 😅 https://github.com/Uniswap/routing-api/blob/main/lib/handlers/injector-sor.ts#L177-L246

@jsy1218 jsy1218 mentioned this pull request Aug 12, 2023
@jsy1218 jsy1218 merged commit fbc0435 into main Aug 12, 2023
2 checks passed
@jsy1218 jsy1218 deleted the jsy1218/fix-base-gas-multichunk branch August 12, 2023 18:53
This was referenced Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants