This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Fixed bug that returned an empty swap router 02 address for base chain #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dallinlarsen This is helpful. It probably explains the regression in Uniswap/smart-order-router#481. I will give a try in my local, and see if it passes. |
|
FYI tracking purpose, regression was introduced in #112 |
jsy1218
approved these changes
Feb 23, 2024
|
@dallinlarsen FYI I'm going to merge your change directly, because it helps with the issue Uniswap/smart-order-router#481 (comment). The contribution credit should still be yours. |
jsy1218
added a commit
that referenced
this pull request
Feb 23, 2024
#120) * Updated code to correctly access addresses * add test to ensure no regression --------- Co-authored-by: jsy1218 <91580504+jsy1218@users.noreply.github.com>
jsy1218
added a commit
that referenced
this pull request
Feb 23, 2024
* fix: add correct addresses for sepolia * Fixed bug that returned an empty swap router 02 address for base chain (#120) * Updated code to correctly access addresses * add test to ensure no regression --------- Co-authored-by: jsy1218 <91580504+jsy1218@users.noreply.github.com> * Fix code style issues with Prettier * enhance testing coverage * Fix code style issues with Prettier --------- Co-authored-by: dallinlarsen <56076097+dallinlarsen@users.noreply.github.com> Co-authored-by: jsy1218 <91580504+jsy1218@users.noreply.github.com> Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
This was referenced Feb 23, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recieiving an error:
Error: resolver or addr is not configured for ENS name (argument="name", value="", code=INVALID_ARGUMENT, version=contracts/5.7.0)and tracked it down to this bug. It seems that calling
includes()on the array works butchainId in SUPPORTED_CHAINSdoesn't.