Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error summary as per GDS Design system #167

Open
sulthan-ahmed opened this issue Jun 25, 2019 · 0 comments
Open

Update error summary as per GDS Design system #167

sulthan-ahmed opened this issue Jun 25, 2019 · 0 comments

Comments

@sulthan-ahmed
Copy link
Contributor

sulthan-ahmed commented Jun 25, 2019

The current error summary is out of date. It doesn't follow the guidelines in the GDS Design system
You must:

  • add ‘Error: ’ to the beginning of the <title> so screen readers read it out as soon as possible ☑️
  • show an error summary at the top of a page ☑️
  • move keyboard focus to the error summary
  • include the heading ‘There is a problem’ ☑️
  • link to each of the answers that have validation errors ☑️
  • show the same error messages next to the inputs with errors ☑️

It was agreed at least the first two items should be addressed. There is some debate about changing the focus because that changes the default behaviour of a browser

Updated: added a check to all the items done in this issue

https://design-system.service.gov.uk/components/error-summary/

sulthan-ahmed added a commit to UKHomeOfficeForms/hof-template-partials that referenced this issue Jun 26, 2019
As GDS guidelines move error summary to the top
UKHomeOfficeForms/hof#167
sulthan-ahmed added a commit to UKHomeOfficeForms/hof-template-partials that referenced this issue Jun 26, 2019
As GDS guidelines move error summary to the top UKHomeOfficeForms/hof#167
sulthan-ahmed added a commit to UKHomeOfficeForms/hof-template-partials that referenced this issue Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant