Patch plotly pdf #348
Merged
Patch plotly pdf #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The plots look really good! Minor thing is it possible to make this one bigger? or the points smaller? It just looks a little jumbled, like hard to see where the lines go to the points etc and the plot itself is small relative to the axes' sizes |
|
AFAIK, I can't make the plot bigger, but I may be able to decrease the point size a little bit. These are not ideal plots for pdf... |
|
I have tried for as long as I can currently budget time to fix the point size in PDF programmatically, and I cannot. So for the classification plot I am resorting to a screenshot for now. But will open an issue that this is still not ideal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reproducibly generates high resolution static plotly figures for the pdf. It depends on the
reticulate+ thepython-kaleidopackage - which have been added to theDockerfile. This means we need to now use the Docker image with the versionv0.16.0now. I have updated the build scripts to reflect this.Note: I had to downsize the point size in the plotly figures to make them work for PDF. If they are now too smal for html (they are smaller, but I am not sure if it is too small) then we need to have the if statement also conditionally control the point size.
Closes: