Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-fill recording update on issues #444

Open
8 tasks done
fbanados opened this issue Jun 18, 2024 · 21 comments
Open
8 tasks done

Pre-fill recording update on issues #444

fbanados opened this issue Jun 18, 2024 · 21 comments
Assignees

Comments

@fbanados
Copy link
Member

fbanados commented Jun 18, 2024

Recording update should have several improvements:

  • Pre-fill Speaker code
  • Distinguish behaviour between updating speaker and wrong word
  • Ensure comments are kept after resolution
  • Add a field for stem and lexical category
  • When available, associated recordings should be directly accessible from the recording update to confirm a valid candidate.
  • "Wrong word" should be able to associate with pre-existing phrases in the dictionary, by search.
  • Exact same phrases (transcription+translations) should be merged automatically
  • An interface for manually merging phrases would be useful.

See also: #443

@fbanados
Copy link
Member Author

fbanados commented Aug 13, 2024

I've updated the interface a bit to deal with the first part of this issue (pre-fill for speaker code and word, plus auto-complete for wrong word)
Screenshot 2024-08-12 at 6 27 59 PM

This has been deployed. I made sure to restart the image after adding static files so it should not have the issues of last time (missing css)

@fbanados fbanados self-assigned this Aug 16, 2024
@fbanados
Copy link
Member Author

@aarppe Do we want to add fields for lexical category and stem or just make available the analysis field that is already in the database to be edited on issues?

@fbanados
Copy link
Member Author

From our discussion today, something like this for an intermediate quality state?
Screenshot 2024-08-26 at 5 53 13 PM

(will revisit the colour tomorrow to make it darker)

@fbanados
Copy link
Member Author

fbanados added a commit that referenced this issue Aug 27, 2024
@fbanados
Copy link
Member Author

All currently ticked changes have been deployed.

@fbanados
Copy link
Member Author

fbanados commented Sep 5, 2024

Last two items should be a separate issue.

@aarppe
Copy link
Collaborator

aarppe commented Sep 12, 2024

When selecting an issue directly from the speaker view, autocomplete doesn't seem to work, cf. below one would expect to see pahkonikêw in the replacement window, not pahkonêw.

image

@aarppe aarppe reopened this Sep 12, 2024
@aarppe
Copy link
Collaborator

aarppe commented Sep 12, 2024

Same here - the comment gives the correct speaker code, i.e. BL2, but that isn't auto-copied to the field that shows BRI instead, cf.

image

@fbanados
Copy link
Member Author

A refactoring performed in 2021 changed names of fields, so the suggestion fields for this cases (likely for all issues before Sep 2021) are empty. There should have been a data migration added, but it looks like this was not the case.

I will have to make a migration pass that tries to extract the information from the comment, which seems to be the only place where that information remains in the database.

@fbanados
Copy link
Member Author

I was this close to saying "new issues should not have the problem", but it looks like they do too. I will look into this in further detail.

@aarppe
Copy link
Collaborator

aarppe commented Sep 12, 2024

Ok, in principle the information should be in the appropriate field, for the wrong speaker and wrong word cases.

As a reminder for ourselves, we do also have a general Comment field in the Linguistic view, which could contain all sorts of information (including stems, inflectional categories, and derivational morphological make-up), but not guaranteedly in an always systematic extractable format.

@fbanados
Copy link
Member Author

Currently, new "wrong word" issues work, but not new "wrong speaker" issues, because wrong speaker issues only store the information in the comment. As we have to fix this anyways for old "wrong word", I'll do both on the same pass.

fbanados added a commit that referenced this issue Sep 12, 2024
@fbanados
Copy link
Member Author

(Transferred from incorrect issue)

A fix is ready to deploy, but I'll wait until Daniel tells me he's done (or tomorrow morning, whichever happens first) to avoid issues.

Just as a side note, Speaker Code suggestion is only available from June 2021 onwards. Word suggestions exist from almost the beginning.

@fbanados
Copy link
Member Author

Updated entries on speech-db.

@fbanados
Copy link
Member Author

@aarppe would you like the interface for issues to only show the field that should be changed in the issue? (say, only speaker or only phrase?), or keep it as it is?

@aarppe
Copy link
Collaborator

aarppe commented Sep 17, 2024

Storing this for reference. Sometimes the comment has the correct speaker code (here: ARL), but the pre-filled code is still the old one (here: BL2): https://speech-db.altlab.app/maskwacis/issues/5

image image

@fbanados
Copy link
Member Author

This behaviour is expected. You are in a different issue than the one on the card. The current issue has no speaker:
Screenshot 2024-09-17 at 12 14 39 PM

There is a different issue that does have the right speaker annotation:

Screenshot 2024-09-17 at 12 15 31 PM

If you go to the details of that issue, (Clicking on "More info"), the speaker is autocompleted.

@fbanados
Copy link
Member Author

Request: resolve all issues of the same kind when clicking on resolve.

@fbanados
Copy link
Member Author

Change Merge phrases to entries.

@fbanados
Copy link
Member Author

Merge for "câh-cakataham mîtosa namôya nikî-nipân" is not working with a 403 forbidden

@fbanados
Copy link
Member Author

Must generate the "linguist-admin" role that can merge items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

2 participants