Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joyent/node-manta#290 Switch muntar over to use tar-stream #367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joyent-automation
Copy link

#290 Switch muntar over to use tar-stream

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/1037/.
The raw archive of this CR is here.
See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

@trentm commented at 2016-12-02T23:17:46

Patch Set 1: Code-Review+1

Gah. I spent time scratching my head how dirs are handled by muntar then realized there is already #259 for that (hint hint, if you want jperkin). :)

Code looks good to me and works with the couple tars I tried.

How do we decide we are comfortable enough to release this? tar-stream has some tests at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants