Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add, use, and document new function tribits_external_package_create_imported_all_libs_target_and_config_file() (#299) #493

Commits on Jun 30, 2022

  1. Add some space between long lower-case function arguments

    I think this needs to be a CMake code formatting guideline.  It makes the code
    more readable since CMake lacks commas to seprate arguments.
    bartlettroscoe committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    6784225 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    508ffc7 View commit details
    Browse the repository at this point in the history
  3. Factor out tribits_external_package_create_imported_all_libs_target_a…

    …nd_config_file() (TriBITSPub#299)
    
    This is a reusable function that can be used with many other such
    FindTPL<tplName>.cmake files that call find_package(<externalPkg>) that
    defines imported targets.
    bartlettroscoe committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    a610ca3 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Update all TribitsExampleProject2 TPLs to use find_package() (TriBITS…

    …Pub#299)
    
    Now all of the TribitsExampleProject2 TPLs Tpl1, Tpl2, Tpl3, and Tpl4 all can
    call:
    
      tribits_external_package_create_imported_all_libs_target_and_config_file()
    
    to be able to use the externally generated `<externalPkg>Config.cmake` files.
    
    I also updated the tests for TribitsExampleProject2 and TribitsExampleApp2 to
    ensure that find_package() is being called (by grepping the output).  I feel
    pretty good about these tests.
    TribitsExampleProject2
    bartlettroscoe committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    edcb87f View commit details
    Browse the repository at this point in the history
  2. Add missing reference to ${PACKAGE_NAME}_LIB_ALL_DEPENDENCIES (TriBIT…

    …SPub#299)
    
    It just points to the maintainers guide for now.  May need a local users guide
    reference for this.
    bartlettroscoe committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    0425f4c View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Include TribitsExternalPackageFindTplHelpers.cmake in TribitsProcessE…

    …nabledTpl.cmake (TriBITSPub#299)
    
    This makes it so that individual FindTPL<tplName>.cmake files don't need to
    include this module.
    bartlettroscoe committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    27d20e1 View commit details
    Browse the repository at this point in the history
  2. Remove trailing spaces at the end of each line (TriBITSPub#299)

    I noticed this while working on TriBITSPub#299 so I decided to just fix this.
    bartlettroscoe committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    1f74e3a View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Add/update documentation for TriBITS TPLs (TriBITSPub#299)

    I did several things here:
    
    * Updated howto for creating TriBITS FindTPL<tplName>.cmake files to cover all
      cases with more examples.  This also covers the new function
      tribits_external_package_create_imported_all_libs_target_and_config_file()
    
    * Changed section name from "Addtional Topics" to "Miscellaneous Topics"
    
    * Changes section name from "TriBITS TPL" to "TriBITS External Package/TPL"
      but provided anchor `TriBITS TPL`_ so I did not have to update all of the
      references.
    
    * Provided subsections for TriBITS External Package/TPL files and variables
    
    * Moved detailed material on tricky aspects of find_package() and
      <tplName>Config.cmake files to a new section "Tricky considerations for
      TriBITS-generated <tplName>Config.cmake files".
    
    * Added references to documentation for the functions in the module
      TribitsExternalPackageWriteConfigFile.cmake.
    bartlettroscoe committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    c81102e View commit details
    Browse the repository at this point in the history