Skip to content

Commit

Permalink
Update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
andres97medrano committed Jan 25, 2024
1 parent e960ae9 commit db60ae3
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ internal struct CreateProvisioningProfileCommand: ParsableCommand {
certificateSigningRequestSubject: try container.decode(String.self, forKey: .certificateSigningRequestSubject),
bundleIdentifierName: try container.decodeIfPresent(String.self, forKey: .bundleIdentifierName),
platform: try container.decode(String.self, forKey: .platform),
profileName: try container.decode(String.self, forKey: .profileName)
profileName: try container.decodeIfPresent(String.self, forKey: .profileName)
)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ final class CreateProvisioningProfileCommandTests: XCTestCase {
"opensslPath": "/opensslPath",
"certificateSigningRequestSubject": "certificateSigningRequestSubject",
"bundleIdentifierName": "bundleIdentifierName",
"platform": "platform"
"platform": "platform",
"profileName": "profileName"
}
""".utf8)

Expand All @@ -181,6 +182,7 @@ final class CreateProvisioningProfileCommandTests: XCTestCase {
XCTAssertEqual(subject.outputPath, "/outputPath")
XCTAssertEqual(subject.bundleIdentifierName, "bundleIdentifierName")
XCTAssertEqual(subject.platform, "platform")
XCTAssertEqual(subject.profileName, "profileName")
}

func test_execute_alreadyActiveCertificate() throws {
Expand Down
6 changes: 3 additions & 3 deletions Tests/SignHereLibraryTests/iTunesConnectServiceTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ final class iTunesConnectServiceTests: XCTestCase {
certificateId: "certificateId",
deviceIDs: .init(["deviceId"]),
profileType: "profileType",
profileName: "profileName"
profileName: nil
)

// THEN
Expand Down Expand Up @@ -598,7 +598,7 @@ final class iTunesConnectServiceTests: XCTestCase {
certificateId: "certificateId",
deviceIDs: .init(["deviceId"]),
profileType: "IOS_APP_STORE",
profileName: "profileName"
profileName: nil
)

// THEN
Expand Down Expand Up @@ -627,7 +627,7 @@ final class iTunesConnectServiceTests: XCTestCase {
certificateId: "certificateId",
deviceIDs: .init(["deviceId"]),
profileType: "profileType",
profileName: "profileName"
profileName: nil
)) {
if case iTunesConnectServiceImp.Error.unableToDecodeResponse = $0 {
return
Expand Down

0 comments on commit db60ae3

Please sign in to comment.