This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
Catch and log fix #192
Merged
Catch and log fix #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samadritsarkar2
added a commit
to samadritsarkar2/node-ytsr-dump-fix
that referenced
this pull request
Apr 15, 2023
Taken from TimeForANinja#192
|
hey, any plan on resolving the checks and merging this in? looking to stop the dumps from happening at all. |
|
Hello there! I am really sorry as I did not see the messages before. I've gone ahead and made a commit fixing the checks. I hope this helps! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Looks fine to me. |
|
🎉 This PR is included in version 3.8.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting a
EACCES: permission deniederror when it tried to create the dump file.I think that it would be better if it would log the error first and then create the dump file, and in case it can't, log the error to the console. This is because if the error appeared when writting the file, it would neither write the file nor log the error.