Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add prettier #7

Merged
merged 2 commits into from
Jan 21, 2020
Merged

chore: Add prettier #7

merged 2 commits into from
Jan 21, 2020

Conversation

baleeds
Copy link

@baleeds baleeds commented Jan 21, 2020 •
edited
Loading

This PR will:

  • Add prettier
  • Run prettier on every applicable file
  • Add prettier script in package to run on every file

Points of contention:

  • Prettier won't run on .sass files. We could change to .scss format (I'll do it, I also prefer it, for it's similarity to other forms of CSS).

@baleeds
Copy link
Author

baleeds commented Jan 21, 2020

If we merge this in, I will rebase the other PR against it and we should see less noise.

@baleeds baleeds requested a review from TimboKZ January 21, 2020 16:41
@TimboKZ TimboKZ merged commit ac415f5 into TimboKZ:master Jan 21, 2020
@TimboKZ TimboKZ mentioned this pull request Jan 21, 2020
Merged
samuelncui pushed a commit to samuelncui/Chonky that referenced this pull request Oct 4, 2023
@paralin
Merge pull request TimboKZ#7 from aperturerobotics/dependabot/npm_and…
3823593 
…_yarn/deepmerge-4.3.0

Bump deepmerge from 4.2.2 to 4.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimboKZ TimboKZ TimboKZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baleeds @TimboKZ