Meson cleanup #619
Merged
Meson cleanup #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests cannot contain a ":", and configuring the example produced the following warning: test/test_runners/meson.build:12: DEPRECATION: ":" is not allowed in test name "Running: 01-test-case", it has been replaced with "_" test/test_runners/meson.build:13: DEPRECATION: ":" is not allowed in test name "Running: 02-test-case", it has been replaced with "_" In this case, the "running" part is redundant, so remove it.
The main project doesn't really have any specific version requirement. Specify a very low one just in case -- 0.37.0 is old enough to cover probably any existing use of Meson anywhere in the wild, and coincidentally is also the version that Meson started adding feature warnings for, to notify you if you use too-new features. The example *does* depend on a specific version. It needs 0.55.0 in order to use subproject wrap dependency fallback instead of the legacy style of specifying the name of the variable as a fallback. Ensure that is used.
This is useful to help convey the usage rights and e.g. generate a Software Bill of Materials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.