Fix events stored with no stream_type #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m110
reviewed
Feb 22, 2023
| @@ -35,10 +35,18 @@ type Entity[T any] interface { | |||
| // NewEntity instantiates a new T with the given events applied to it. | |||
| // At the same time the entity's internal Stream is initialised, | |||
| // so it can record new upcoming stream. | |||
| func NewEntity[T Entity[T]](id string, eventsSlice []VersionedEvent[T]) (*T, error) { | |||
| func NewEntity[T Entity[T]]( | |||
There was a problem hiding this comment.
We could consider keeping this one and adding NewEntityWithStreamType for easier use when we don't care about the stream type (like in the in-memory repository).
|
@m110, I have fixed the issue you have found and simplified the implementation a little bit. Can you have another look, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug-fix for #31
The root problem was the fact that when loading events from the DB and creating a new instance of an Entity with stream injected, the
stream_typeproperty was ignored. In consequence, a new instance was created with emptystream_typeand all of the subsequent events were stored without it.I run the tests before and after the change and it proves the issue is gone now.
Before
After
