Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.7 join using #554

Closed
pieczarkazsolt opened this issue Nov 25, 2016 · 2 comments
Closed

v2.7 join using #554

pieczarkazsolt opened this issue Nov 25, 2016 · 2 comments

Comments

@pieczarkazsolt
Copy link

hi, in v2.7 join not working with USING (only with ON):

$this->_query .= " " . $joinType. " JOIN " . $joinStr ." on " . $joinCondition;
protected function _buildJoinOld() {
.
.
.
$this->_query .= " " . $joinType . " JOIN " . $joinStr . 
                (false !== stripos($joinCondition, 'using') ? " " : " on ")
                . $joinCondition;
@avbdr
Copy link
Collaborator

avbdr commented Jun 24, 2017

can you please work out a pull request for that?

avbdr added a commit to avbdr/PHP-MySQLi-Database-Class that referenced this issue Aug 8, 2017
@avbdr
Fix for ThingEngineer#554 Fixing Join usage with 'USING' instead of 'ON'
8d4dcb1
@avbdr
Copy link
Collaborator

avbdr commented Aug 8, 2017

fixed. thanks

@avbdr avbdr closed this as completed Aug 8, 2017
avbdr added a commit that referenced this issue Aug 9, 2017
@avbdr
fixes (#673)
d87decd 
* fixed limit variable ordering in the comments

* Expand readme on autoreconnect and multipe connections usage

* update release numbers

* update copyright years

* Bug #623:  Mistake in Regexp

* Fix for #554 Fixing Join usage with 'USING' instead of 'ON'

* Fix empty exception message
ricwein pushed a commit to ricwein/PHP-MySQLi-Database-Class that referenced this issue Aug 29, 2017
@avbdr @ricwein
fixes (ThingEngineer#673)
f1fc9ff 
* fixed limit variable ordering in the comments

* Expand readme on autoreconnect and multipe connections usage

* update release numbers

* update copyright years

* Bug ThingEngineer#623:  Mistake in Regexp

* Fix for ThingEngineer#554 Fixing Join usage with 'USING' instead of 'ON'

* Fix empty exception message
avbdr added a commit that referenced this issue Nov 29, 2017
@avbdr
fixes (#698)
1f45192 
* fixed limit variable ordering in the comments

* Expand readme on autoreconnect and multipe connections usage

* update release numbers

* update copyright years

* Bug #623:  Mistake in Regexp

* Fix for #554 Fixing Join usage with 'USING' instead of 'ON'

* Fix empty exception message

* fix a typo

* Added LIKE case description into readme

* do not reset connection name when transtation is on

* 2.9 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@avbdr @pieczarkazsolt