Skip to content

Commit

Permalink
fix: fix goUp and goDown: make CodeMirror scroll only in fixedHeight …
Browse files Browse the repository at this point in the history
…(it's not needed otherwise)
  • Loading branch information
TheodoreChu committed Dec 15, 2020
1 parent 6187d5e commit 268a87a
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 23 deletions.
6 changes: 3 additions & 3 deletions build/asset-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"static/js/1.94a8704a.chunk.js": "./static/js/1.94a8704a.chunk.js",
"static/js/1.94a8704a.chunk.js.map": "./static/js/1.94a8704a.chunk.js.map",
"main.css": "./static/css/main.365342b3.chunk.css",
"main.js": "./static/js/main.c30d7197.chunk.js",
"main.js.map": "./static/js/main.c30d7197.chunk.js.map",
"main.js": "./static/js/main.cf56b8e1.chunk.js",
"main.js.map": "./static/js/main.cf56b8e1.chunk.js.map",
"runtime-main.js": "./static/js/runtime-main.4405e875.js",
"runtime-main.js.map": "./static/js/runtime-main.4405e875.js.map",
"static/css/4.7c0a8645.chunk.css": "./static/css/4.7c0a8645.chunk.css",
Expand Down Expand Up @@ -162,6 +162,6 @@
"static/css/4.7c0a8645.chunk.css",
"static/js/4.8f86dee5.chunk.js",
"static/css/main.365342b3.chunk.css",
"static/js/main.c30d7197.chunk.js"
"static/js/main.cf56b8e1.chunk.js"
]
}
2 changes: 1 addition & 1 deletion build/index.html
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" type="image/png" href="./icon.png"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="The Append Editor is an unofficial editor for Standard Notes, a free, open-source, and end-to-end encrypted notes app. Try the demo at beta.appendeditor.com or learn more at appendeditor.com."/><link rel="apple-touch-icon" href="./icon192.png"/><link rel="manifest" href="./manifest.json"/><link rel="stylesheet" href="./katex/v0.12.0/katex.min.css" integrity="sha384-AfEj0r4/OFrOo5t7NnNe46zW/tFgW6x/bCJG8FqQCEo3+Aro6EYUG4+cU+KJWu/X" crossorigin="anonymous"/><title>Append Editor</title><link href="./static/css/4.7c0a8645.chunk.css" rel="stylesheet"><link href="./static/css/main.365342b3.chunk.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div><script src="editor.worker.bundle.js"></script><script src="json.worker.bundle.js"></script><script src="css.worker.bundle.js"></script><script src="html.worker.bundle.js"></script><script src="ts.worker.bundle.js"></script><script>!function(e){function r(r){for(var a,o,f=r[0],d=r[1],u=r[2],i=0,l=[];i<f.length;i++)o=f[i],Object.prototype.hasOwnProperty.call(n,o)&&n[o]&&l.push(n[o][0]),n[o]=0;for(a in d)Object.prototype.hasOwnProperty.call(d,a)&&(e[a]=d[a]);for(b&&b(r);l.length;)l.shift()();return c.push.apply(c,u||[]),t()}function t(){for(var e,r=0;r<c.length;r++){for(var t=c[r],a=!0,f=1;f<t.length;f++){var d=t[f];0!==n[d]&&(a=!1)}a&&(c.splice(r--,1),e=o(o.s=t[0]))}return e}var a={},n={3:0},c=[];function o(r){if(a[r])return a[r].exports;var t=a[r]={i:r,l:!1,exports:{}};return e[r].call(t.exports,t,t.exports,o),t.l=!0,t.exports}o.e=function(e){var r=[],t=n[e];if(0!==t)if(t)r.push(t[2]);else{var a=new Promise((function(r,a){t=n[e]=[r,a]}));r.push(t[2]=a);var c,f=document.createElement("script");f.charset="utf-8",f.timeout=120,o.nc&&f.setAttribute("nonce",o.nc),f.src=function(e){return o.p+"static/js/"+({}[e]||e)+"."+{0:"39eaacde",1:"94a8704a",5:"a177ed4b",6:"05c4187d",7:"ab471150",8:"d0b9a72a",9:"d1f41cce",10:"763c08cc",11:"ba4fa629",12:"5e807283",13:"5baa6acb",14:"54a7d892",15:"15fecc7f",16:"e01fb9b0",17:"b7185cca",18:"1097a363",19:"6f717f9b",20:"20fd559a",21:"f62af302",22:"a022f41f",23:"87d98a6c",24:"fac9919a",25:"1a023eec",26:"7650a72a",27:"d156e25b",28:"416d21dd",29:"1a796f6d",30:"7bc991c8",31:"5de30043",32:"b32b80ad",33:"5c73a938",34:"7cad957d",35:"5bd68534",36:"8d01591a",37:"69562bfd",38:"91bd981a",39:"ad84387b",40:"19160149",41:"065333df",42:"a2daad98",43:"7ee02558",44:"22493baf",45:"3076e21f",46:"acb07196",47:"e5856dcb",48:"c61dcccc",49:"74883327",50:"d55bc92d",51:"7a0e96e1",52:"b171d0b6",53:"89d043e5",54:"ca7cb7b9",55:"d7651d53",56:"96b2c909",57:"38c08e50",58:"06c76a6b",59:"7bfa8249",60:"5bbdd121",61:"fbf4f30e",62:"3b9e2cf8",63:"ab17e2bc",64:"e934aa47",65:"3aec7f39",66:"0a93a5fb",67:"a69f4bc4",68:"45463cfd",69:"34bff24b",70:"bd5b7f44",71:"8abfd081",72:"0093180a",73:"a6cb7cb2"}[e]+".chunk.js"}(e);var d=new Error;c=function(r){f.onerror=f.onload=null,clearTimeout(u);var t=n[e];if(0!==t){if(t){var a=r&&("load"===r.type?"missing":r.type),c=r&&r.target&&r.target.src;d.message="Loading chunk "+e+" failed.\n("+a+": "+c+")",d.name="ChunkLoadError",d.type=a,d.request=c,t[1](d)}n[e]=void 0}};var u=setTimeout((function(){c({type:"timeout",target:f})}),12e4);f.onerror=f.onload=c,document.head.appendChild(f)}return Promise.all(r)},o.m=e,o.c=a,o.d=function(e,r,t){o.o(e,r)||Object.defineProperty(e,r,{enumerable:!0,get:t})},o.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},o.t=function(e,r){if(1&r&&(e=o(e)),8&r)return e;if(4&r&&"object"==typeof e&&e&&e.__esModule)return e;var t=Object.create(null);if(o.r(t),Object.defineProperty(t,"default",{enumerable:!0,value:e}),2&r&&"string"!=typeof e)for(var a in e)o.d(t,a,function(r){return e[r]}.bind(null,a));return t},o.n=function(e){var r=e&&e.__esModule?function(){return e.default}:function(){return e};return o.d(r,"a",r),r},o.o=function(e,r){return Object.prototype.hasOwnProperty.call(e,r)},o.p="./",o.oe=function(e){throw console.error(e),e};var f=this["webpackJsonpappend-editor"]=this["webpackJsonpappend-editor"]||[],d=f.push.bind(f);f.push=r,f=f.slice();for(var u=0;u<f.length;u++)r(f[u]);var b=d;t()}([])</script><script src="./static/js/4.8f86dee5.chunk.js"></script><script src="./static/js/main.c30d7197.chunk.js"></script></body></html>
<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" type="image/png" href="./icon.png"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="The Append Editor is an unofficial editor for Standard Notes, a free, open-source, and end-to-end encrypted notes app. Try the demo at beta.appendeditor.com or learn more at appendeditor.com."/><link rel="apple-touch-icon" href="./icon192.png"/><link rel="manifest" href="./manifest.json"/><link rel="stylesheet" href="./katex/v0.12.0/katex.min.css" integrity="sha384-AfEj0r4/OFrOo5t7NnNe46zW/tFgW6x/bCJG8FqQCEo3+Aro6EYUG4+cU+KJWu/X" crossorigin="anonymous"/><title>Append Editor</title><link href="./static/css/4.7c0a8645.chunk.css" rel="stylesheet"><link href="./static/css/main.365342b3.chunk.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div><script src="editor.worker.bundle.js"></script><script src="json.worker.bundle.js"></script><script src="css.worker.bundle.js"></script><script src="html.worker.bundle.js"></script><script src="ts.worker.bundle.js"></script><script>!function(e){function r(r){for(var a,o,f=r[0],d=r[1],u=r[2],i=0,l=[];i<f.length;i++)o=f[i],Object.prototype.hasOwnProperty.call(n,o)&&n[o]&&l.push(n[o][0]),n[o]=0;for(a in d)Object.prototype.hasOwnProperty.call(d,a)&&(e[a]=d[a]);for(b&&b(r);l.length;)l.shift()();return c.push.apply(c,u||[]),t()}function t(){for(var e,r=0;r<c.length;r++){for(var t=c[r],a=!0,f=1;f<t.length;f++){var d=t[f];0!==n[d]&&(a=!1)}a&&(c.splice(r--,1),e=o(o.s=t[0]))}return e}var a={},n={3:0},c=[];function o(r){if(a[r])return a[r].exports;var t=a[r]={i:r,l:!1,exports:{}};return e[r].call(t.exports,t,t.exports,o),t.l=!0,t.exports}o.e=function(e){var r=[],t=n[e];if(0!==t)if(t)r.push(t[2]);else{var a=new Promise((function(r,a){t=n[e]=[r,a]}));r.push(t[2]=a);var c,f=document.createElement("script");f.charset="utf-8",f.timeout=120,o.nc&&f.setAttribute("nonce",o.nc),f.src=function(e){return o.p+"static/js/"+({}[e]||e)+"."+{0:"39eaacde",1:"94a8704a",5:"a177ed4b",6:"05c4187d",7:"ab471150",8:"d0b9a72a",9:"d1f41cce",10:"763c08cc",11:"ba4fa629",12:"5e807283",13:"5baa6acb",14:"54a7d892",15:"15fecc7f",16:"e01fb9b0",17:"b7185cca",18:"1097a363",19:"6f717f9b",20:"20fd559a",21:"f62af302",22:"a022f41f",23:"87d98a6c",24:"fac9919a",25:"1a023eec",26:"7650a72a",27:"d156e25b",28:"416d21dd",29:"1a796f6d",30:"7bc991c8",31:"5de30043",32:"b32b80ad",33:"5c73a938",34:"7cad957d",35:"5bd68534",36:"8d01591a",37:"69562bfd",38:"91bd981a",39:"ad84387b",40:"19160149",41:"065333df",42:"a2daad98",43:"7ee02558",44:"22493baf",45:"3076e21f",46:"acb07196",47:"e5856dcb",48:"c61dcccc",49:"74883327",50:"d55bc92d",51:"7a0e96e1",52:"b171d0b6",53:"89d043e5",54:"ca7cb7b9",55:"d7651d53",56:"96b2c909",57:"38c08e50",58:"06c76a6b",59:"7bfa8249",60:"5bbdd121",61:"fbf4f30e",62:"3b9e2cf8",63:"ab17e2bc",64:"e934aa47",65:"3aec7f39",66:"0a93a5fb",67:"a69f4bc4",68:"45463cfd",69:"34bff24b",70:"bd5b7f44",71:"8abfd081",72:"0093180a",73:"a6cb7cb2"}[e]+".chunk.js"}(e);var d=new Error;c=function(r){f.onerror=f.onload=null,clearTimeout(u);var t=n[e];if(0!==t){if(t){var a=r&&("load"===r.type?"missing":r.type),c=r&&r.target&&r.target.src;d.message="Loading chunk "+e+" failed.\n("+a+": "+c+")",d.name="ChunkLoadError",d.type=a,d.request=c,t[1](d)}n[e]=void 0}};var u=setTimeout((function(){c({type:"timeout",target:f})}),12e4);f.onerror=f.onload=c,document.head.appendChild(f)}return Promise.all(r)},o.m=e,o.c=a,o.d=function(e,r,t){o.o(e,r)||Object.defineProperty(e,r,{enumerable:!0,get:t})},o.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},o.t=function(e,r){if(1&r&&(e=o(e)),8&r)return e;if(4&r&&"object"==typeof e&&e&&e.__esModule)return e;var t=Object.create(null);if(o.r(t),Object.defineProperty(t,"default",{enumerable:!0,value:e}),2&r&&"string"!=typeof e)for(var a in e)o.d(t,a,function(r){return e[r]}.bind(null,a));return t},o.n=function(e){var r=e&&e.__esModule?function(){return e.default}:function(){return e};return o.d(r,"a",r),r},o.o=function(e,r){return Object.prototype.hasOwnProperty.call(e,r)},o.p="./",o.oe=function(e){throw console.error(e),e};var f=this["webpackJsonpappend-editor"]=this["webpackJsonpappend-editor"]||[],d=f.push.bind(f);f.push=r,f=f.slice();for(var u=0;u<f.length;u++)r(f[u]);var b=d;t()}([])</script><script src="./static/js/4.8f86dee5.chunk.js"></script><script src="./static/js/main.cf56b8e1.chunk.js"></script></body></html>

Large diffs are not rendered by default.

Large diffs are not rendered by default.

32 changes: 16 additions & 16 deletions src/components/AppendEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1490,14 +1490,14 @@ export default class AppendEditor extends React.Component<{}, AppendInterface> {
if (edit) {
edit.scrollTop = 10000000;
}
}
/** Scroll down for CodeMirror */
const codeMirrorList = document.getElementsByClassName(
'CodeMirror-vscrollbar'
);
const codeMirrorEditMode = codeMirrorList[0];
if (codeMirrorEditMode) {
codeMirrorEditMode.scrollTop = 10000000;
/** Scroll down for CodeMirror */
const codeMirrorList = document.getElementsByClassName(
'CodeMirror-vscrollbar'
);
const codeMirrorEditMode = codeMirrorList[0];
if (codeMirrorEditMode) {
codeMirrorEditMode.scrollTop = 10000000;
}
}
};

Expand Down Expand Up @@ -1552,14 +1552,14 @@ export default class AppendEditor extends React.Component<{}, AppendInterface> {
if (edit) {
edit.scrollTop = 0;
}
}
/** Scroll up for CodeMirror */
const codeMirrorList = document.getElementsByClassName(
'CodeMirror-vscrollbar'
);
const codeMirrorEditMode = codeMirrorList[0];
if (codeMirrorEditMode) {
codeMirrorEditMode.scrollTop = 0;
/** Scroll up for CodeMirror */
const codeMirrorList = document.getElementsByClassName(
'CodeMirror-vscrollbar'
);
const codeMirrorEditMode = codeMirrorList[0];
if (codeMirrorEditMode) {
codeMirrorEditMode.scrollTop = 0;
}
}
};

Expand Down

0 comments on commit 268a87a

Please sign in to comment.