Context menu button, Ban Spammer #548

Mclilzee · 2024-06-13T09:44:47Z

Because

Phishing links spam is an ever-increasing occurrence on discord. The mod team have to keep banning these users with the same message so that they know how to contact us if they wish to rejoin the server.

This PR will automate that with a click of a button.

This PR

Adds context menu button to ban spam user
Logs the ban in the appropriate channel
Sends the user a contact information of why they were banned, and how to contact us once they recover their account if DM is not set to private.

Issue

Closes #504

Additional Information

Make sure to change the config.js moderationLog ID to the channel ID of your test server to see the log messages while testing.

There are currently some duplication of functions in some of the other services, I think it would be a good idea to move those to utils. Another duplication happen is with the tests, There is a buildInteraction function in test utils but that one is made for a specific purpose only, I would need to change it and refactor all the tests that calls it in order to generalize it to be used by these new tests. I didn't want this PR to be too big and include those refactors. So I included some create interaction mocks functions in the test files.

Let me know how would you like to proceed with the refactors.

Pull Request Requirements

I have thoroughly read and understand The Odin Project Contributing Guide
The title of this PR follows the location of change: brief description of change format, e.g. Callbacks command: Update verbiage
The Because section summarizes the reason for this PR
The This PR section has a bullet point list describing the changes in this PR
If this PR addresses an open issue, it is linked in the Issue section
If this PR adds new features or functionality, I have added new tests
If applicable, I have ensured all tests related to any command files included in this PR pass, and/or all snapshots are up to date

services/spam-ban/__snapshots__/spam-banning.service.test.js.snap

services/spam-ban/spam-banning.service.js

01zulfi · 2024-07-02T06:28:37Z

services/spam-ban/spam-banning.service.js

+      let reply;
+
+      if (!message.member) {
+        message.react("❌");


I'm assuming we're reacting to the banned message? So this reaction will be done on a message in a public channel? Not sure we'd want that, but do confirm with others though.

The button will be mainly used on automod messages that are blocked and logged, Which only staff can see. We wont be using this for messages that automod fails to block or doesnt delete. We will use manual modding to make sure that any left over spam msgs will be deleted by us.

Okay, so this command is only for the automod messages. Isn't automod a bot though? Won't message.author.bot always return true? How are we able to get the offending user's id from an automod message? I'm drawing blanks on the documentation, so some links could be helpful 😅

I definitely should set up automod in a dummy server to test this myself instead of bombarding this PR lol

Those are valid questions which I myself had, and made up an environment to explore. To my surprise however is that the Autobot logs actually act as if those message were posted by the user. message.author is actually the user who's message is blocked by Automod. Yeah certainly set up an environment and test things out

services/spam-ban/spam-banning.service.js

01zulfi · 2024-07-02T06:31:38Z

services/spam-ban/spam-banning.service.test.js

++ for these tests

services/spam-ban/spam-banning.service.js

Asartea · 2024-07-02T10:54:50Z

config.js

@@ -13,6 +13,7 @@ const config = {
    gettingHiredChannelId: process.env.DISCORD_GETTING_HIRED_CHANNEL_ID,
    botSpamPlaygroundChannelId: '513125912070455296',
    FAQChannelId: '823266307293839401',
+    moderationLog: '922520585018433536'


Presuming (based on context), that this is an channel ID, shouldn't this be moderationLogChannelId to preserve consistency in how we name them

Thats right, this should be a channel ID. ++

services/spam-ban/spam-banning.service.js

Asartea · 2024-07-02T10:59:29Z

services/spam-ban/spam-banning.service.js

+    const embedMessage = new EmbedBuilder()
+      .setTitle("Banned: Compromised account / Spam")
+      .setDescription(
+        `Account is compromised and is used to spam phishing links.


Suggested change

`Account is compromised and is used to spam phishing links.

`Your account has been banned from The Odin Project Discord as it is compromised and is used to spam phishing links.

Asartea · 2024-07-02T11:48:48Z

services/spam-ban/spam-banning.service.js

+        `Account is compromised and is used to spam phishing links.
+
+  If you would still like to continue using our server, make sure to change your password and recover your account.
+  After that send a detailed contact information to appeal the ban on theodinprojectcontact@gmail.com`,


Suggested change

After that send a detailed contact information to appeal the ban on theodinprojectcontact@gmail.com`,

After that send a ban appeal containing contact information to theodinprojectcontact@gmail.com`,

Additional: Not a team member, but it might be easier if the instructions also say to add something like [Ban Appeal] to the subject or send it to something like theodinprojectcontact+banappeals@gmail.com

Your input is valueable and always appreciated. We might also add a template for them to fill in the email too

Asartea · 2024-07-02T11:50:50Z

services/spam-ban/spam-banning.service.js

+    channel.send({ embeds: [embed] });
+  }
+
+  static #isAdmin(member) {


Nit: it might be worth (probably in a follow up) to refactor check if a user is admin logic to a separate file; I think this is either the third or fourth occurrence of basically this exact code snippet

This logic is duplicated in may other services. This is what im indicating in my PR message. Many of those including tests should be moved to utils. But not sure if we are doing it in this PR or an upcoming one, wanted to see what maintainers think.

This has now happened in #567

Thanks for letting me know, I will integrate it

Mclilzee · 2024-07-12T20:26:45Z

@TheOdinProject/moderators I would like the mod team to weigh on this. What the message to the user would be like, what kind of template. And perhaps some kind of a form so that they can use for the appeal?

This is the current template of the message

Account is compromised and is used to spam phishing links.

If you would still like to continue using our server, make sure to change your password and recover your account.
After that send a detailed contact information to appeal the ban on theodinprojectcontact@gmail.com

I would like to especially hear from @JustWaveThings since this was originally your idea, is this how you imagined it to be, or do you think it needs some improvements?

JustWaveThings · 2024-07-12T20:28:55Z

I'll be happy to put together a message to send on the ban. I will look at the functionality of it tonight. Thank you so much for doing this!

JustWaveThings · 2024-07-13T03:43:03Z

@Mclilzee, Here's my take on the message the bot could send:

This account has been banned from The Odin Project Discord server for sending spam. If this account is compromised, please follow the steps linked in this Discord support article to secure your account.

Once your account is secure, you may appeal your ban by emailing theodinprojectcontact@gmail.com with your Discord username and that you are appealing your ban due to a compromised account.

Note: It may take several days for our volunteer staff to take action on your appeal, and unbanning is not guaranteed.

I don't know if we need to get fancy with the message. I'm also fine with just sending what we send now in the ban message.

Mclilzee · 2024-07-13T10:18:27Z

@Mclilzee, Here's my take on the message the bot could send:

This account has been banned from The Odin Project Discord server for sending spam. If this account is compromised, please follow the steps linked in this Discord support article to secure your account.

Once your account is secure, you may appeal your ban by emailing theodinprojectcontact@gmail.com with your Discord username and that you are appealing your ban due to a compromised account.

Note: It may take several days for our volunteer staff to take action on your appeal, and unbanning is not guaranteed.

I don't know if we need to get fancy with the message. I'm also fine with just sending what we send now in the ban message.

This looks great! Thank you, Fred. This is much better than whatever I can cook with my broken English.

Asartea · 2024-07-13T16:53:33Z

Very minor nit, but I think that the starting This should also be an Your, otherwise you're switching between modes of address

MaoShizhong

Just a quick few nits on grammar/spelling etc.

services/spam-ban/spam-banning.service.js

services/spam-ban/spam-banning.service.test.js

new-era-commands/context-menu/bann-spammer.js

services/spam-ban/spam-banning.service.js

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

services/spam-ban/spam-banning.service.js

Co-authored-by: Asartea <76259120+Asartea@users.noreply.github.com>

Asartea

LGTM 🚀

MaoShizhong · 2024-08-11T12:10:48Z

new-era-commands/context-menu/bann-spammer.js

Nit, single n in file name ban-spammer.js.

I probably won't have a great deal of time to do a thorough review of the feature itself, I'm more doing little bits here and there, so I'll be cheeky and leave the rump of the stuff to Xari.

Mclilzee commented Jun 15, 2024

View reviewed changes

services/spam-ban/__snapshots__/spam-banning.service.test.js.snap Outdated Show resolved Hide resolved

Mclilzee changed the title ~~Automated spam ban context menu button~~ Context menu button, Ban Spammer Jul 1, 2024

01zulfi requested changes Jul 2, 2024

View reviewed changes

Asartea reviewed Jul 2, 2024

View reviewed changes

Mclilzee added 21 commits August 8, 2024 08:02

Create context button

f41f9c5

Fix calling wrong service

979c3d9

Refactor naming

7f676a5

Update logic to spammer-banning service

437c2c2

Reformat message to contain new line

9fd096f

Fix contact email

abba810

Reverse to send message directly

b9abfe5

Fix message sending issue

2f14d87

Update structure of calls

adc4216

Add announcing user banning and failure

6ba618b

Refactor

d87a0ef

Update sending error to stderr channel

af62905

Refactor modules

d1aab86

Add tests

1df4b9c

Update tests and use snapshot

95642d4

Finalize first full test

6fb440a

Add second test for users that isn't able to recieve messages

d67ab6f

Add test for user that is not on the server anymore

0615b95

Add function to announce the ban

5ff7903

Refactor naming

4ec49fa

Update tests

f14c8df

Mclilzee added 14 commits August 8, 2024 08:03

Update tests

00a5263

Update channel id name

f75bf98

Refactor channel name id in tests

3bea73d

Update user message

f6f11dd

Update channel id name

a4a2d0e

Update tests

bb6d4e2

Update date object to work with github cli test tools

3f88707

Update to use fetch method on getting the channel

b8a415e

Update to handle fetch promise

bf38ad3

Add handling error when channel is not found

2c8fa34

Remove mailto link in contact user message

b35b524

Send user message to enable embed links

6f8a323

Update message to include new mod email

c6fcd00

Update test snippets

d3ecdb8

Mclilzee force-pushed the automated-spam-bann branch from 156ac29 to d3ecdb8 Compare August 8, 2024 06:08

Mclilzee added 3 commits August 8, 2024 08:11

Remove duplicated key

7cb62f8

Run prettier

fbf17a2

Use new isAdmin util function

1c1f795

MaoShizhong reviewed Aug 8, 2024

View reviewed changes

Apply suggestions from code review

dfad9d9

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

Asartea reviewed Aug 8, 2024

View reviewed changes

services/spam-ban/spam-banning.service.js Outdated Show resolved Hide resolved

Mclilzee and others added 3 commits August 10, 2024 15:25

Update ban message with appeal template

6f87b8f

Refactor sentence structure

4877b72

Co-authored-by: Asartea <76259120+Asartea@users.noreply.github.com>

Update test snippets to reflect newest changes

ccc7030

Mclilzee requested review from 01zulfi, MaoShizhong and Asartea August 10, 2024 19:18

Asartea reviewed Aug 11, 2024

View reviewed changes

MaoShizhong reviewed Aug 11, 2024

View reviewed changes

Update filename

f319ac5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Context menu button, Ban Spammer #548

Context menu button, Ban Spammer #548

Mclilzee commented Jun 13, 2024

01zulfi Jul 2, 2024

Mclilzee Jul 2, 2024

01zulfi Jul 4, 2024

Mclilzee Jul 4, 2024

01zulfi Jul 2, 2024

Asartea Jul 2, 2024 •

edited

Loading

Mclilzee Jul 2, 2024

Asartea Jul 2, 2024

Asartea Jul 2, 2024

Mclilzee Jul 2, 2024

Asartea Jul 2, 2024

Mclilzee Jul 2, 2024

Asartea Aug 6, 2024

Mclilzee Aug 8, 2024

Mclilzee commented Jul 12, 2024

JustWaveThings commented Jul 12, 2024

JustWaveThings commented Jul 13, 2024 •

edited

Loading

Mclilzee commented Jul 13, 2024

Asartea commented Jul 13, 2024 •

edited

Loading

MaoShizhong left a comment

Asartea left a comment

MaoShizhong Aug 11, 2024

	`Account is compromised and is used to spam phishing links.
	`Your account has been banned from The Odin Project Discord as it is compromised and is used to spam phishing links.

	After that send a detailed contact information to appeal the ban on theodinprojectcontact@gmail.com`,
	After that send a ban appeal containing contact information to theodinprojectcontact@gmail.com`,

Context menu button, Ban Spammer #548

Are you sure you want to change the base?

Context menu button, Ban Spammer #548

Conversation

Mclilzee commented Jun 13, 2024

Because

This PR

Issue

Additional Information

Pull Request Requirements

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Asartea Jul 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mclilzee commented Jul 12, 2024

JustWaveThings commented Jul 12, 2024

JustWaveThings commented Jul 13, 2024 • edited Loading

Mclilzee commented Jul 13, 2024

Asartea commented Jul 13, 2024 • edited Loading

MaoShizhong left a comment

Choose a reason for hiding this comment

Asartea left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Asartea Jul 2, 2024 •

edited

Loading

JustWaveThings commented Jul 13, 2024 •

edited

Loading

Asartea commented Jul 13, 2024 •

edited

Loading