Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch related to Timezone fix #269

Closed
wants to merge 2 commits into from
Closed

Conversation

shmsr
Copy link

@shmsr shmsr commented Nov 11, 2019

PR apache#7667: Remove non-UTC epoch logic
PR apache#8450: Making client time use UTC as the local time

It should fix the timezone related error.

Reason for this behaviour is that epoch difference was taken with the server's timezone rather than UTC always. But our epoch is UTC based only, so there was an unusual time offset.

For reference:

if is_epoch_in_utc:
                seconds_since_epoch = dttm.timestamp()
            else:
                seconds_since_epoch = (dttm - datetime(1970, 1, 1)).total_seconds()
            seconds_since_epoch = int(seconds_since_epoch)

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

PR apache#8450: Making client time use UTC as the local time
PR apache#7667: Remove non-UTC epoch logic
@shmsr shmsr changed the title Patches related to Timezone fix Patch related to Timezone fix Nov 13, 2019
@shmsr shmsr closed this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants