Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assert. fix #878 #914 #924

Merged
merged 16 commits into from
May 17, 2018

Conversation

wsdwsd0829
Copy link
Contributor

_editingTransactionGroupCount may become 0 right after editingTransactionQueueBusy check.
Since _editingTransactionGroupCount is atomic it's sufficient to tell if all processing is down or not.

@ghost
Copy link

ghost commented May 17, 2018

1 Warning
⚠️ Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep makes sense – this is a non-atomic operation. Thanks Max!

@Adlai-Holler Adlai-Holler merged commit 62dd3ca into TextureGroup:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants