Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NSIndexSet+ASHelpers.h reference local #trivial #857

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Make NSIndexSet+ASHelpers.h reference local #trivial #857

merged 2 commits into from
Mar 28, 2018

Conversation

dmaclach
Copy link
Contributor

NSIndexSet+ASHelpers.h should be a user vs a system or framework include.

NSIndexSet+ASHelpers.h should be a user vs a system or framework include.
@CLAassistant
Copy link

CLAassistant commented Mar 27, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. However, we want to stick to framework import as much as possible. Could you please update it to “#import <AsyncDisplayKit/NSIndexSet+ASHelpers.h”? Thanks!

@@ -13,7 +13,7 @@
#import "ASIntegerMap.h"
#import <AsyncDisplayKit/ASAssert.h>
#import <unordered_map>
#import "NSIndexSet+ASHelpers.h"
#import <AsyncDisplayKit/NSIndexSet+ASHelpers.h>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmaclach LGTM

@maicki maicki changed the title Make NSIndexSet+ASHelpers.h reference local Make NSIndexSet+ASHelpers.h reference local #trivial Mar 27, 2018
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thank you!

@nguyenhuy nguyenhuy merged commit cf1c3f6 into TextureGroup:master Mar 28, 2018
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
* Make NSIndexSet+ASHelpers.h reference local

NSIndexSet+ASHelpers.h should be a user vs a system or framework include.

* Update ASIntegerMap.mm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants