Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synchronous state of node if +viewClass or +layerClass is overwritten #trivial #776

Merged
merged 3 commits into from
Jan 31, 2018

Conversation

maicki
Copy link
Contributor

@maicki maicki commented Jan 30, 2018

No description provided.

Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

_layerClass = [self.class layerClass];

Copy link
Member

@nguyenhuy nguyenhuy Jan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do the same for +layerClass, in case the node is layer-backed.

@maicki maicki changed the title Fix synchronous state of node if +viewClass is overwritten #trivial Fix synchronous state of node if +viewClass or +layerClass is overwritten #trivial Jan 30, 2018
@maicki maicki force-pushed the MSFixSynchronousStateOfNodeIfViewClassOverwritten branch from a1546c5 to f164f2b Compare January 30, 2018 21:33
@maicki maicki force-pushed the MSFixSynchronousStateOfNodeIfViewClassOverwritten branch from f164f2b to 7339fbf Compare January 30, 2018 23:29
@maicki maicki merged commit 20e31f7 into master Jan 31, 2018
@maicki maicki deleted the MSFixSynchronousStateOfNodeIfViewClassOverwritten branch January 31, 2018 17:57
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
…tten #trivial (TextureGroup#776)

* Fix synchronous state of node if +viewClass is overwritten

* Also check for _layerClass overwrite for synchronous flag

* Update some code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants