Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PINCache #769

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Conversation

justinswart
Copy link
Contributor

Similar to the issue described in pinterest/PINRemoteImage#363, I've been experiencing the runtime error dyld: Symbol not found: _PINDiskCachePrefix when using Carthage and Texture in my project.

The solution described in the referenced issue is to checkout PINRemoteImage separately, run carthage update and then copy the built frameworks over. This works and appears to be because PINRemoteImage references PINCache at the 3.0.1-beta.6 release.

I've updated Texture's Cartfile in this PR to also reference PINCache at 3.0.1-beta.6. This does appear to solve the runtime error for my project so I'm suggesting this change for others that may experience this crash.

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since we're doing the same for PINRemoteImage. Would love to have approval from another maintainer as well, maybe especially @garrettmoon?

Btw, thank you for the diff, @justinswart.

@justinswart
Copy link
Contributor Author

Sure thing, hope it helps someone else!

Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, as it's always good to be explicit with dependency versions.

@Adlai-Holler Adlai-Holler merged commit 7ba4376 into TextureGroup:master Jan 30, 2018
fumito-ito added a commit to fumito-ito/RxASDataSources that referenced this pull request Apr 4, 2018
Older PINCache causes runtime erorr sometimes.
To avoid this problem, set version of PINCache.

refs: TextureGroup/Texture#769
dangthaison91 pushed a commit to RxSwiftCommunity/RxASDataSources that referenced this pull request Apr 24, 2018
* use newer PINCache to avoid runtime error

Older PINCache causes runtime erorr sometimes.
To avoid this problem, set version of PINCache.

refs: TextureGroup/Texture#769

* use PINCache 3.0.1-beta.6 or later

with submodule reference
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants