Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yoga version #569

Merged
merged 3 commits into from
Sep 16, 2017
Merged

Update yoga version #569

merged 3 commits into from
Sep 16, 2017

Conversation

wsdwsd0829
Copy link
Contributor

No description provided.

@wsdwsd0829
Copy link
Contributor Author

need some of changes like
image
which solves problems like unnecessary layout passes caused by text rounding problem for @2x @3x

@nguyenhuy
Copy link
Member

Refer to @appleguy for a final say here :)

appleguy
appleguy approved these changes Sep 16, 2017
View reviewed changes
Copy link
Member

@appleguy appleguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Max! This does have some important fixes and I know of an app team that has shipped with 1.6 successfully :).

@appleguy appleguy merged commit b9b2d7e into TextureGroup:master Sep 16, 2017
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
@wsdwsd0829 @bernieperez
Update yoga version (TextureGroup#569)
1d02143 
* fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449

* update yoga version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleguy appleguy appleguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wsdwsd0829 @nguyenhuy @appleguy