ASCollectionLayout to return a zero content size if its state is unavailable #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source/Private/ASCollectionLayout.mm
Outdated
| @@ -140,8 +140,7 @@ - (void)invalidateLayout | |||
| - (CGSize)collectionViewContentSize | |||
| { | |||
| ASDisplayNodeAssertMainThread(); | |||
| ASDisplayNodeAssertNotNil(_layout, @"Collection layout state should not be nil at this point"); | |||
| return _layout.contentSize; | |||
| return _layout ? _layout.contentSize : CGSizeZero; | |||
There was a problem hiding this comment.
So that we don't regress on this in the future, could you add a link to this PR explaining the workaround?
nguyenhuy
force-pushed
the
HNHandleUnavaiLayoutState
branch
from
1863575
to
bc24130
Compare
Adlai-Holler
approved these changes
Aug 16, 2017
|
Thanks, @Adlai-Holler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @wsdwsd0829 here.
Reproducible in "examples/ASCollectionView" by enabling
ASYNC_COLLECTION_LAYOUTand popping the view controller after just 2 seconds (this line). The crash occurs when a containing view controller is popped out right after its collection view finished a batch update, but before an update animation settles. As soon as the view controller is deallocated, its collection view's layout is invalidated. Then when the update animation stops, it asks for the layout's content size and triggers the assertion. Fix by returning a zero size instead.