Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update to use ASCornerLayoutSpec for Photo with Outset Icon Overlay #1721

Merged
merged 1 commit into from
Nov 12, 2019
Merged

[Docs] Update to use ASCornerLayoutSpec for Photo with Outset Icon Overlay #1721

merged 1 commit into from
Nov 12, 2019

Conversation

hanton
Copy link
Contributor

@hanton hanton commented Nov 5, 2019

Update to use ASCornerLayoutSpec for Photo with Outset Icon Overlay.

vovasty
vovasty approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@vovasty vovasty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR!

@hanton
Copy link
Contributor Author

hanton commented Nov 12, 2019

The CI failed with the following message:

▸ Compiling Launchboard.storyboard
** BUILD FAILED **

The following build commands failed:
	CompileAssetCatalog /Users/runner/ASDKDerivedData/Build/Products/Debug-iphonesimulator/Sample.app /Users/runner/runners/2.160.0/work/Texture/Texture/examples/CustomCollectionView/Sample/Images.xcassets
(1 failure)

I think it is not related to the PR :)

@vovasty vovasty merged commit be96501 into TextureGroup:master Nov 12, 2019
@hanton hanton deleted the docs-update-layout-examples branch November 13, 2019 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vovasty vovasty vovasty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanton @vovasty