Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Opting-Out of Linking with Photos Framework #1519

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Fix Opting-Out of Linking with Photos Framework #1519

merged 1 commit into from
Jun 3, 2019

Conversation

b3ll
Copy link
Contributor

@b3ll b3ll commented May 26, 2019

AS_USE_PHOTOS currently allows opting out of linking with the Photos framework / Photos features of Texture, however with the ASMultiplexImageNode header, it still imports from the Photos framework and when "Automatically Link with Frameworks" is enabled, it'll link with Photos.framework.

This fixes that by conditionally importing / excluding unavailable API based on whether or not AS_USE_PHOTOS is enabled.

@CLAassistant
Copy link

CLAassistant commented May 26, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @b3ll for fixing!

@Adlai-Holler Adlai-Holler merged commit 1b4b6a3 into TextureGroup:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants