Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all ASDisplayNode properties have backing ivars for consistency. #1475

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Make sure all ASDisplayNode properties have backing ivars for consistency. #1475

merged 2 commits into from
Apr 30, 2019

Commits on Apr 30, 2019

  1. Make sure all ASDisplayNodes have backing ivars for consistency. 

    Found this by enabling `#pragma clang diagnostic error "-Wobjc-missing-property-synthesis"` for `ASDisplayNode`. One property is unused, saving 8 bytes of heap space per instance. Implement setter/getters for these properties. Do they need to be locked?
    Greg Bolsinga committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    29d1b00 View commit details
    Browse the repository at this point in the history

  2. add locks where needed. embed property synthesis warning/error into h… 

    …eader.
    Greg Bolsinga committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    ea2b66a View commit details
    Browse the repository at this point in the history