Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated implementations warning #1306

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

maicki
Copy link
Contributor

@maicki maicki commented Jan 7, 2019

Seems like Xcode 10.1 introduces some new warnings. Either we should prevent them via Xcode settings or like in this PR guard them via a compiler flag.

@maicki maicki force-pushed the MSCleanupDeprecatedMethodWarning branch from cdb7966 to 680e6ea Compare January 10, 2019 08:04
@maicki
Copy link
Contributor Author

maicki commented Jan 14, 2019

@Adlai-Holler Want to give that another look please. Thank!

Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nguyenhuy nguyenhuy merged commit 7a782f8 into master Jan 17, 2019
@maicki maicki deleted the MSCleanupDeprecatedMethodWarning branch January 18, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants