Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable a11y cache #1274

Merged
merged 2 commits into from
Dec 9, 2018
Merged

Conversation

wsdwsd0829
Copy link
Contributor

@wsdwsd0829 wsdwsd0829 commented Dec 7, 2018

Disable because a11y not update correctly as layer backed nodes inserted/removed/updated.
A few other case will fail otherwise as shown in tests.

Fixes: #1161
Attempt to invalidate a11y (instead of disable cache) code is here: #1260 while does not seem worth the effort.

Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits aside, LGTM. Changes in the framework are minimal.


@interface ASDisplayViewAccessibilityTests : XCTestCase
@end

@implementation ASDisplayViewAccessibilityTests

- (void)setUp {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bracket on the following line please.

NSArray<UIAccessibilityElement *> *updatedElements2 = contianer.view.accessibilityElements;
XCTAssertTrue([[updatedElements2.firstObject accessibilityLabel] isEqualToString:@"hello, world, !!!!"]);
}
- (void)testAccessibilityNonLayerbackedNodesOperationInContainer {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Also separate these methods by new lines.

@maicki maicki changed the title disable a11y cache Disable a11y cache Dec 8, 2018
Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @wsdwsd0829

@maicki maicki merged commit 4d9d3c2 into TextureGroup:master Dec 9, 2018
wsdwsd0829 added a commit to wsdwsd0829/Texture that referenced this pull request Mar 14, 2019
* disable a11y cache

* style update
wsdwsd0829 added a commit to wsdwsd0829/Texture that referenced this pull request Mar 15, 2019
* disable a11y cache

* style update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants