Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Swift Example #1002

Merged
merged 2 commits into from
Jul 8, 2018
Merged

Rewrite Swift Example #1002

merged 2 commits into from
Jul 8, 2018

Conversation

maicki
Copy link
Contributor

@maicki maicki commented Jul 1, 2018

  • Switch to Unsplash API
  • Use new 4.x features like Codable
  • Cleanup code
  • We should think of moving this example back into the normal examples folder

Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through the source code and looks fine to me. Requesting changes since I think it's important to preserve the original copyright of OrderedDictionary. Will approve as soon as it's fixed.

@@ -0,0 +1,610 @@
/// A generic collection for storing key-value pairs in an ordered manner.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to include copyright and license notices of the original author here.

Copy link
Contributor Author

@maicki maicki Jul 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I will change that, but also ask him if he can merge in the Cocoapods PR they have open so we can just pull it in via that. That said I changed some stuff around to improve the runtime of checking if a key is in the dictionary that I will try to get in the main repo before.

@maicki
Copy link
Contributor Author

maicki commented Jul 4, 2018

@nguyenhuy Just added the license header to OrderedDictionary for now before we can pull it in via Cocoapods

@ghost
Copy link

ghost commented Jul 4, 2018

1 Warning
⚠️ This is a big PR, please consider splitting it up to ease code review.

Generated by 🚫 Danger

@maicki maicki merged commit c8b5a1b into master Jul 8, 2018
@maicki maicki deleted the MSRewriteSwiftExample branch July 29, 2018 15:33
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
* Rewrite Swift Example

* Add license header to OrderedDictionary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants