[ASCollectionView] sizeForElement: may call out to the delegate for constraint while in a different index-space #438
Comments
appleguy
added a commit
that referenced
this issue
Jul 14, 2017
…for missing UICollectionViewLayout properties This is a first attempt at resolving #438. I know there is already one similar method to do indexPath conversions, and that the #define for accessing properties on the UICollectionViewFlowLayout should probably be moved somewhere else. Looking for feedback on the general direction here. In particular, I'm a bit surprised that so much has changed in how these calls occur, as I believe especially constrainedSizeForNodeAtIndexPath: is now called with inconsistent index path spaces (but was not before this PR landed in March: https://github.com/facebookarchive/AsyncDisplayKit/pull/3136/files) Since the impact of mixing the spaces is fairly serious (can cause crashes), I'm also wondering if I am misinterpreting some aspects of the code, or if maybe the crashing impact wasn't noticed yet.
nguyenhuy
pushed a commit
that referenced
this issue
Jul 17, 2017
…for missing UICollectionViewLayout properties. (#440) * [ASCollectionView] Add delegate bridging and index space translation for missing UICollectionViewLayout properties This is a first attempt at resolving #438. I know there is already one similar method to do indexPath conversions, and that the #define for accessing properties on the UICollectionViewFlowLayout should probably be moved somewhere else. Looking for feedback on the general direction here. In particular, I'm a bit surprised that so much has changed in how these calls occur, as I believe especially constrainedSizeForNodeAtIndexPath: is now called with inconsistent index path spaces (but was not before this PR landed in March: https://github.com/facebookarchive/AsyncDisplayKit/pull/3136/files) Since the impact of mixing the spaces is fairly serious (can cause crashes), I'm also wondering if I am misinterpreting some aspects of the code, or if maybe the crashing impact wasn't noticed yet. * [ASCollectionView] Cleanup and final changes for UIKit passthrough fixes.
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this issue
Apr 25, 2018
…for missing UICollectionViewLayout properties. (TextureGroup#440) * [ASCollectionView] Add delegate bridging and index space translation for missing UICollectionViewLayout properties This is a first attempt at resolving TextureGroup#438. I know there is already one similar method to do indexPath conversions, and that the #define for accessing properties on the UICollectionViewFlowLayout should probably be moved somewhere else. Looking for feedback on the general direction here. In particular, I'm a bit surprised that so much has changed in how these calls occur, as I believe especially constrainedSizeForNodeAtIndexPath: is now called with inconsistent index path spaces (but was not before this PR landed in March: https://github.com/facebookarchive/AsyncDisplayKit/pull/3136/files) Since the impact of mixing the spaces is fairly serious (can cause crashes), I'm also wondering if I am misinterpreting some aspects of the code, or if maybe the crashing impact wasn't noticed yet. * [ASCollectionView] Cleanup and final changes for UIKit passthrough fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I believe this is a regression since -calculatedSize was swapped for layoutThatFits:. To my knowledge, it isn't valid to call out to the delegate here, as the item being sized (satisfying request directly from UICollectionViewLayout) is referenced in the UIKit index space -- whereas the call being delivered to the application delegate would access the app index space.
The text was updated successfully, but these errors were encountered: