[iOS 13] Clipping Corners are Incompatible with Dynamic Colors #1673
Comments
shamanskyh
added a commit
to shamanskyh/Texture
that referenced
this issue
Sep 13, 2019
…yle Changes This PR addresses an issue I raised with TextureGroup#1673 where the clipping corner layer doesn't get re-rendered when going from a dark to light user interface style. The fix is to add code in the `-asyncTraitCollectionDidChangeWithPreviousTraitCollection:` method that calls through to `-_updateClipCornerLayerContentsWithRadius:backgroundColor:` if the user interface style changes. I've also added snapshot tests to verify that using clipping corners with a dynamic background color updates when the user interface style changes.
shamanskyh
added a commit
to shamanskyh/Texture
that referenced
this issue
Sep 16, 2019
…clipping corner layer doesn't get re-rendered when going from a dark to light user interface style. The fix is to add code in the `-asyncTraitCollectionDidChangeWithPreviousTraitCollection:` method that calls through to `-_updateClipCornerLayerContentsWithRadius:backgroundColor:` if the user interface style changes. I've also added snapshot tests to verify that using clipping corners with a dynamic background color updates when the user interface style changes. Turn off record mode, remove errant newline This PR addresses an issue I raised with TextureGroup#1673 where the clipping corner layer doesn't get re-rendered when going from a dark to light user interface style. The fix is to add code in the `-asyncTraitCollectionDidChangeWithPreviousTraitCollection:` method that calls through to `-_updateClipCornerLayerContentsWithRadius:backgroundColor:` if the user interface style changes. I've also added snapshot tests to verify that using clipping corners with a dynamic background color updates when the user interface style changes. Turn off record mode, remove errant newline
rahul-malik
pushed a commit
that referenced
this issue
Sep 16, 2019
…1674) * This PR addresses an issue I raised with #1673 where the clipping corner layer doesn't get re-rendered when going from a dark to light user interface style. The fix is to add code in the `-asyncTraitCollectionDidChangeWithPreviousTraitCollection:` method that calls through to `-_updateClipCornerLayerContentsWithRadius:backgroundColor:` if the user interface style changes. I've also added snapshot tests to verify that using clipping corners with a dynamic background color updates when the user interface style changes.
|
Fixed with #1674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The problem:
If I have an ASDisplayNode with a corner radius and corner rounding type set to
ASCornerRoundingTypeClipping, and my ASDisplayNode has a dynamic background color, the corner layer doesn't seem to update when the trait collection's user interface style changes.I'm going to investigate more, but I think the solution is going to be an additional call to
_updateClipCornerLayerContentsWithRadiuswhen the trait collection changes its interface style. Internally, we're tracking this as BUG-99048.The text was updated successfully, but these errors were encountered: