Disable state locking if incrementing state with ACTION #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug report from Elomavi that you could still softlock from warping to ship and incrementing the gamestate by pressing ACTION, which is diverging behavior from how it was in 2.3. Warping to ship and incrementing by pressing ACTION is useful behavior for a couple niche speedrun categories. I had already fixed this earlier by ignoring state locking if glitchrunner 2.2 or 2.0 was enabled, but softlocks could still happen because having glitchrunner mode off still enabled you to increment the gamestate when otherwise unintended. Softlocks shouldn't happen. But without removing state locking entirely, I've chosen a middle ground where it will only be disabled if you press ACTION. That signifies intent that you still want to perform state incrementing glitches even with glitchrunner mode off (but in the future it could be considered a 2.3/2.4 glitch that could be patched and made re-enable-able). That way, casual players can't interrupt the warp to ship by accident (unless they accidentally press ACTION) while softlocks will be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug report from Elomavi that you could still softlock from warping to ship and incrementing the gamestate by pressing ACTION, which is diverging behavior from how it was in 2.3. Warping to ship and incrementing by pressing ACTION is useful behavior for a couple niche speedrun categories.
I had already fixed this earlier by ignoring state locking if glitchrunner 2.2 or 2.0 was enabled, but softlocks could still happen because having glitchrunner mode off still enabled you to increment the gamestate when otherwise unintended. Softlocks shouldn't happen.
But without removing state locking entirely, I've chosen a middle ground where it will only be disabled if you press ACTION. That signifies intent that you still want to perform state incrementing glitches even with glitchrunner mode off (but in the future it could be considered a 2.3/2.4 glitch that could be patched and made re-enable-able). That way, casual players can't interrupt the warp to ship by accident (unless they accidentally press ACTION) while softlocks will be removed.
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement