Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scaling modes manually #1140

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Conversation

AllyTally
Copy link
Contributor

Changes:

For future PRs, it'll be very nice to have full control over how VVVVVV gets drawn to the window. This means we can use the entire window size for things like touch input, drawing borders, or anything we want.

Legal Stuff:

By submitting this pull request, I confirm that...

  • My changes may be used in a future commercial release of VVVVVV
  • I will be credited in a CONTRIBUTORS file and the "GitHub Friends"
    section of the credits for all of said releases, but will NOT be compensated
    for these changes unless there is a prior written agreement

@InfoTeddy
Copy link
Collaborator

Conflicts need to be resolved.

For future PRs, it'll be very nice to have full control over how VVVVVV
gets drawn to the window. This means we can use the entire window size
for things like touch input, drawing borders, or anything we want.
Copy link
Collaborator

@InfoTeddy InfoTeddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides a minor style nitpick this LGTM.

desktop_version/src/Graphics.cpp Outdated Show resolved Hide resolved
Co-authored-by: Misa Elizabeth Kai <infoteddy@infoteddy.info>
@InfoTeddy InfoTeddy merged commit 3e57d66 into TerryCavanagh:master Feb 4, 2024
4 checks passed
@AllyTally AllyTally deleted the letterbox branch March 25, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants