Allow overriding state lock in glitchrunner mode 2.2 or 2.0 #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression where attempting to warp to ship with a trinket text box open in glitchrunner 2.0, and then incrementing the gamestate afterwards, would result in a softlock. This is a speedrunning strat that speedrunners use. The state lock wasn't ever intended to remove any strats or anything, just fix warping to ship under normal circumstances. So it's okay to re-enable interrupting the state by having glitchrunner enabled. This bug was reported by mohoc in the VVVVVV Speedrunning Discord server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression where attempting to warp to ship with a trinket text box open in glitchrunner 2.0, and then incrementing the gamestate afterwards, would result in a softlock. This is a speedrunning strat that speedrunners use.
The state lock wasn't ever intended to remove any strats or anything, just fix warping to ship under normal circumstances. So it's okay to re-enable interrupting the state by having glitchrunner enabled.
This bug was reported by mohoc in the VVVVVV Speedrunning Discord server.
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement