Revert text image fading #1110
Merged
Revert text image fading #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the following commits: - 29f05c4 - f1bf1f6 - a7b2291 - 2ed1aac Recently, text images were changed to fade in with textboxes, where before they previously appeared after the fade. This created a charming effect where the images would appear to "load in" once the textbox finishes fading in. This behavior really complements the retro aesthetic the game is going for. Changing it to a fade is a needless change in direction, as it was not a bug in the first place and looked good already. Additionally, custom levels have used text images (levelcomplete and gamecomplete) in creative ways by replacing them with something else to show as 'foreground' or as a cutscene image. Changing text images to fade has unintended consequences for levels that have utilized them in this fashion.
|
We can disable fading if the graphics are customized. |
|
I mentioned that as an aside - I prefer the non fading behavior for all text images, customized or not. It looked good as it was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This reverts the following commits:
Recently, text images were changed to fade in with textboxes, where before they previously appeared after the fade. This created a charming effect where the images would appear to "load in" once the textbox finishes fading in. This behavior really complements the retro aesthetic the game is going for. Changing it to a fade is a needless change in direction, as it was not a bug in the first place and looked good already.
Additionally, custom levels have used text images (levelcomplete and gamecomplete) in creative ways by replacing them with something else to show as 'foreground' or as a cutscene image. Changing text images to fade has unintended consequences for levels that have utilized them in this fashion.
Current behavior, with fades (in English and Arabic):
english_before.mp4
before_arabic.mp4
Without fades (behavior before today):
english_after.mp4
arabic_after.mp4
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes