Indicate modes when loading in to gameplay #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daaaav
suggested changes
Jan 7, 2024
InfoTeddy
force-pushed
the
mode-indicators
branch
3 times, most recently
from
e7be905
to
8301760
Compare
Daaaav
suggested changes
Jan 8, 2024
InfoTeddy
force-pushed
the
mode-indicators
branch
from
8301760
to
151b61e
Compare
If you load in to gameplay with invincibility mode, glitchrunner mode, Flip Mode, or slowdown enabled, then there will be text displayed on screen for a few seconds that says so. This is to serve as a useful reminder. A common pitfall with using invincibility is forgetting to turn it off when you don't want it anymore. What usually happens is that players forget that they have it on until they encounter a hazard. Now, they can realize it as soon as they load in. See #1091.
InfoTeddy
force-pushed
the
mode-indicators
branch
from
151b61e
to
94e578a
Compare
Daaaav
added a commit
to Daaaav/VVVVVV
that referenced
this pull request
Jan 20, 2024
These were not in the English or any other language files. They should be though, so that they can be translated and generally kept track of. These aren't urgent either, since we have proxy strings that are used if these are untranslated.
Daaaav
added a commit
to Daaaav/VVVVVV
that referenced
this pull request
Jan 20, 2024
These were not in the English or any other language files. They should be though, so that they can be translated and generally kept track of. These aren't urgent either, since we have proxy strings that are used if these are untranslated.
Merged
2 tasks
InfoTeddy
pushed a commit
that referenced
this pull request
Jan 20, 2024
These were not in the English or any other language files. They should be though, so that they can be translated and generally kept track of. These aren't urgent either, since we have proxy strings that are used if these are untranslated.
NyakoFox
pushed a commit
to NyakoFox/VVVVVV
that referenced
this pull request
Apr 16, 2024
These were not in the English or any other language files. They should be though, so that they can be translated and generally kept track of. These aren't urgent either, since we have proxy strings that are used if these are untranslated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you load in to gameplay with invincibility mode, glitchrunner mode, Flip Mode, or slowdown enabled, then there will be text displayed on screen for a few seconds that says so.
This is to serve as a useful reminder. A common pitfall with using invincibility is forgetting to turn it off when you don't want it anymore. What usually happens is that players forget that they have it on until they encounter a hazard. Now, they can realize it as soon as they load in.
The only reason this is a draft pull request is because there is an issue with the Japanese translation where some menu option strings I would like to reuse, e.g. "Glitchrunner mode is {version}", can't be reused on account of them being genericized in Japanese (i.e. they say "Mode: OFF" and that gets reused across multiple strings). Waiting on this to be resolved before merging.Actually instead I'll use the header strings which definitely can't be generic.Fixes #1091.
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes