Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast-forward does not work in 30-FPS-only mode #1185

Closed
InfoTeddy opened this issue Jul 13, 2024 · 0 comments · Fixed by #1186
Closed

Fast-forward does not work in 30-FPS-only mode #1185

InfoTeddy opened this issue Jul 13, 2024 · 0 comments · Fixed by #1186
Assignees
@InfoTeddy
Labels
bug required for 2.4

Comments

@InfoTeddy
Copy link
Collaborator

The level debugger's fast-forward functionality (accessible by holding down F with the debug menu active) only works in over-30-FPS mode. It does not work if the framerate mode is set to 30 FPS only.

Thanks to AllyTally for originally reporting this on Discord.
@InfoTeddy InfoTeddy self-assigned this Jul 13, 2024
InfoTeddy added a commit to InfoTeddy/VVVVVV that referenced this issue Jul 13, 2024
@InfoTeddy
Use variable timestep for SDL_Delay
24c2605 
This fixes a bug where fast-forward wouldn't work in 30-FPS-only mode.

This is because the 30-FPS-only code has a hardcoded check for the
number 34, as in 34 milliseconds must pass before the next frame can
advance. This is why slowdown still worked, because slowdown means
you're waiting longer than 34 ms anyways, but fast-forward tries to wait
for only 1 ms, which wouldn't work if the 34 limit was still enforced.

So instead, swap out the 34 with game.get_timestep() and this will be
fixed.

Fixes TerryCavanagh#1185.
@InfoTeddy InfoTeddy mentioned this issue Jul 13, 2024
Merged
2 tasks
InfoTeddy added a commit to InfoTeddy/VVVVVV that referenced this issue Jul 13, 2024
@InfoTeddy
Use variable timestep for SDL_Delay
a5d05eb 
This fixes a bug where fast-forward wouldn't work in 30-FPS-only mode.

This is because the 30-FPS-only code has a hardcoded check for the
number 34, as in 34 milliseconds must pass before the next frame can
advance. This is why slowdown still worked, because slowdown means
you're waiting longer than 34 ms anyways, but fast-forward tries to wait
for only 1 ms, which wouldn't work if the 34 limit was still enforced.

So instead, swap out the 34 with game.get_timestep() and this will be
fixed.

Fixes TerryCavanagh#1185.
InfoTeddy added a commit that referenced this issue Jul 21, 2024
@InfoTeddy
Use variable timestep for SDL_Delay
6930bde 
This fixes a bug where fast-forward wouldn't work in 30-FPS-only mode.

This is because the 30-FPS-only code has a hardcoded check for the
number 34, as in 34 milliseconds must pass before the next frame can
advance. This is why slowdown still worked, because slowdown means
you're waiting longer than 34 ms anyways, but fast-forward tries to wait
for only 1 ms, which wouldn't work if the 34 limit was still enforced.

So instead, swap out the 34 with game.get_timestep() and this will be
fixed.

Fixes #1185.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@InfoTeddy InfoTeddy

Labels
bug required for 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use variable timestep for SDL_Delay InfoTeddy/VVVVVV
1 participant
@InfoTeddy