Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(search): remove controlled feature & refactor placeholder #195

Merged
merged 1 commit into from
Feb 23, 2022
Merged

refactor(search): remove controlled feature & refactor placeholder #195

merged 1 commit into from
Feb 23, 2022

Conversation

LeeJim
Copy link
Collaborator

@LeeJim LeeJim commented Feb 23, 2022

Search:

  • 移除受控用法
  • 支持双向绑定
  • 重写 placeholder 的实现机制

jin0209
jin0209 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@jin0209 jin0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jin0209 jin0209 merged commit 07c0926 into develop Feb 23, 2022
@jin0209 jin0209 deleted the refactor/search-0223 branch February 23, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jin0209 jin0209 jin0209 approved these changes

@JJunYang JJunYang Awaiting requested review from JJunYang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeeJim @jin0209