Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collapse): 无障碍支持 #1224

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

gzzhanghao
Copy link
Contributor

@gzzhanghao gzzhanghao commented Dec 14, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #1055

💡 需求背景和解决方案

  • cell 的 a11y 不确定合入时间,因此先在 header 外层包裹一个 view 元素,增加 bind:tap 和 aria 属性
  • wrapper 增加 aria-hidden 属性

📝 更新日志

  • feat(Collapse): 支持无障碍访问

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

录屏

iOS:

19_1670997070.mp4

Android:

3_1670999384.mp4
  • Android 录屏第一次点击 collapse 后,焦点跳到了“网页视图”,可能是华为读屏模式的问题,试了下 weui 小程序也会有同样的问题。

@LeeJim LeeJim added the a11y 无障碍访问 label Dec 14, 2022
@syxysszyw
Copy link
Collaborator

预览

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

qrcode

Copy link
Collaborator

@syxysszyw syxysszyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LeeJim LeeJim merged commit 81399d3 into Tencent:develop Dec 16, 2022
@github-actions github-actions bot mentioned this pull request Dec 19, 2022
LeeJim added a commit that referenced this pull request Dec 20, 2022
* feat: BackTop组件读屏焦点优化 (#1206)

* fix(toast): hide noactive-content, screen-reader can be to read the message (#1210)

fix #1029

* feat(count-down): support aria (#1207)

* feat: CountDown组件读屏焦点优化

* feat: 修改count-down的aria-role

* feat: update count-dow snapshots

Co-authored-by: beedeng <beedeng@tencent.com>

* fix(tabbar): resolve safe area on round theme (#1223)

* fix(tabbar): resolve safe area on round theme

* fix(tabbar): update demo

* feat(Input): extended attribute type (#1188)

* feat(steps): using new style (#1225)

* feat(steps): using new style

* feat(steps): support css variables

* feat(steps): finish new style and update demo

* test(steps): update snapshots

* test(steps): update snapshots

* chore: optimize setIcon function (#1232)

* feat(button): support aria (#1149)

* feat(button): button aria

* feat(button): button label

* test(button): update snap

* feat(button): icon hidden when content

* feat(button): icon hidden

* chore(button): update snap

* feat(collapse): add a11y support (#1224)

* feat(calendar): 增加无障碍支持 (#1217)

* feat(calendar): add a11y support

* feat(collapse): add a11y support

* feat(calendar): add 24rpx padding for close button

* feat(SwipeCell): support icon (#1201)

* feat(fab): support aria (#1231)

* feat(fab): support aria

* chore(fab): update snap

* feat(tabs): support aria (#1227)

* feat(tabs): support aria

* chore(tabs): update snap

* feat(tabs): tablist

* chore(tabs): update snap

* feat(dialog): using new style (#1240)

* feat(dialog): using new style

* feat(dialog): finish new style

* feat(dialog): resolve some detail problem

* fix(dialog): remove useless css

* test(dialog): resolve bug

* feat(dialog): support css variables

* test: update snapshot

* Feat/new picker (#1248)

* feat(picker): using new style

* feat(date-time-picker): update demo

* test(date-time-picker): update snapshot

* docs(date-time-picker): update readme

* chore: publish 0.31.0 (#1249)

* chore: publish 0.31.0

* chore: changelog's changes

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feature(popup)/support aria (#1189)

* feat: tempo

* feat(popup): remove redundancy

* fix(overlay): label

* fix(popup): remove redundancy

* chore(popup): update snap

* fix(overlay): reduce tips

Co-authored-by: bee <beeinszu@gmail.com>
Co-authored-by: huaiyinfeilong <huaiyinfeilong@163.com>
Co-authored-by: beedeng <beedeng@tencent.com>
Co-authored-by: Y <anly_yaw@163.com>
Co-authored-by: zhangpaopao <zhangpaopao0609@gmail.com>
Co-authored-by: Jason <jason.daurus@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y 无障碍访问
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Collapse] 无障碍支持
3 participants