feat(dom): fix trigger error on layout event

Tencent · Sep 8, 2023 · 3624aa4 · 3624aa4
1 parent a82a4c3
commit 3624aa4
Showing 1 changed file with 14 additions and 13 deletions.
diff --git a/dom/src/dom/dom_node.cc b/dom/src/dom/dom_node.cc
@@ -322,6 +322,7 @@ LayoutResult DomNode::GetLayoutInfoFromRoot() {
 void DomNode::TransferLayoutOutputsRecursive(std::vector<std::shared_ptr<DomNode>>& changed_nodes) {
   auto not_equal = std::not_equal_to<>();
   bool changed =  layout_node_->IsDirty() || layout_node_->HasNewLayout();
+  bool has_new_layout = layout_node_->HasNewLayout();
 
   layout_.left = layout_node_->GetLeft();
   layout_.top = layout_node_->GetTop();
@@ -364,19 +365,19 @@ void DomNode::TransferLayoutOutputsRecursive(std::vector<std::shared_ptr<DomNode
     layout_param[kLayoutHeightKey] = HippyValue(layout_.height);
     HippyValueObjectType layout_obj;
     layout_obj[kLayoutLayoutKey] = layout_param;
-    auto event =
-        std::make_shared<DomEvent>(kLayoutEvent,
-                                   weak_from_this(),
-                                   std::make_shared<HippyValue>(std::move(layout_obj)));
-    auto root = root_node_.lock();
-    if (root != nullptr) {
-      auto manager = root->GetDomManager().lock();
-      if (manager != nullptr) {
-        std::vector<std::function<void()>> ops = {[WEAK_THIS, event] {
-          DEFINE_AND_CHECK_SELF(DomNode)
-          self->HandleEvent(event);
-        }};
-        manager->PostTask(Scene(std::move(ops)));
+    if (has_new_layout) {
+      auto event = std::make_shared<DomEvent>(kLayoutEvent, weak_from_this(),
+                                              std::make_shared<HippyValue>(std::move(layout_obj)));
+      auto root = root_node_.lock();
+      if (root != nullptr) {
+        auto manager = root->GetDomManager().lock();
+        if (manager != nullptr) {
+          std::vector<std::function<void()>> ops = {[WEAK_THIS, event] {
+            DEFINE_AND_CHECK_SELF(DomNode)
+            self->HandleEvent(event);
+          }};
+          manager->PostTask(Scene(std::move(ops)));
+        }
       }
     }
   }